This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef.
Created attachment 106009 [details] [review] Bug 25805: SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present!
Created attachment 106029 [details] [review] Bug 25805: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 106030 [details] [review] Bug 25805: SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 106078 [details] [review] Bug 25805: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 106079 [details] [review] Bug 25805: SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, regressions tests present and passes qa scripts. Passing QA
Please adjust the description of the main patch.
(In reply to Jonathan Druart from comment #7) > Please adjust the description of the main patch. How would you like it adjusted?
To describe what the patch does, not what the problem is (ie. not a copy/paste of the bug report title).
Created attachment 106257 [details] [review] Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.02
backported to 19.11.x for 19.11.08
Backported to 19.05.x branch for 19.05.14