Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is a problem with the patron.
Created attachment 106059 [details] [review] Bug 25815: SIP Checkout: add more information on why the patron is blocked. Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is a problem with the patron. This patch adds more specific informations, with the following messages: - "Patron expired" - "Patron debarred" - "Patron has fines" (see system preference "noissuescharge") - "Patron blocked" (see system preference "OverduesBlockCirc") Test plan: - Try to do a SIP checkout with a patron that is in one of the above situations. - Check that the displayed message matches the patron's situation.
I tested on my kohadevbox, with the different cases and the SIP responses are the one expected.
Created attachment 132652 [details] [review] Bug 25815: SIP Checkout: add more information on why the patron is blocked. Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is a problem with the patron. This patch adds more specific informations, with the following messages: - "Patron expired" - "Patron debarred" - "Patron has fines" (see system preference "noissuescharge") - "Patron blocked" (see system preference "OverduesBlockCirc") Test plan: - Try to do a SIP checkout with a patron that is in one of the above situations. - Check that the displayed message matches the patron's situation. Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr>
Unit tests, please
Also, charge ok order is debarred, expired, fines, blocked - you move expired first - we should be consistent
Thanks for your feedback, Nick. The following patch restores the correct order and adds unit tests.
Created attachment 133215 [details] [review] updated patch
Created attachment 133397 [details] [review] Bug 25815: SIP Checkout: add more information on why the patron is blocked. Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is a problem with the patron. This patch adds more specific informations, with the following messages: - "Patron expired" - "Patron debarred" - "Patron has fines" (see system preference "noissuescharge") - "Patron blocked" (see system preference "OverduesBlockCirc") Test plan: - Try to do a SIP checkout with a patron that is in one of the above situations. - Check that the displayed message matches the patron's situation. Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Issues raised by Nick all fixed and patch all works as expected here. QA scripts are happy, and we have Unit tests.. Passing QA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Created attachment 155593 [details] [review] Bug 25815: (QA follow-up) Add system preference Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>