Bug 25828 - Update cpanfile for 20.05 release cycle
Summary: Update cpanfile for 20.05 release cycle
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Mason James
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-20 03:05 UTC by Mason James
Modified: 2020-11-19 10:29 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
RMNOTE: This has been reverted
Version(s) released in:


Attachments
Bug 25828: Update cpanfile for 20.05 release cycle (1.97 KB, patch)
2020-06-20 03:08 UTC, Mason James
Details | Diff | Splinter Review
Bug 25828: Update cpanfile for 20.05 release cycle (2.00 KB, patch)
2020-06-23 08:17 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2020-06-20 03:05:50 UTC
This patch updates the cpanfile for the 20.05 release cycle
Comment 1 Mason James 2020-06-20 03:08:20 UTC
Created attachment 106111 [details] [review]
Bug 25828: Update cpanfile for 20.05 release cycle

to test...
 1/ check about.pl, see old module versions

 2/ apply patch

 3/ check about.pl, see updated module versions
Comment 2 Mason James 2020-06-20 03:09:38 UTC
please apply patch to master, 20.05 and 19.11 branches
Comment 3 Martin Renvoize 2020-06-23 08:17:14 UTC
Created attachment 106180 [details] [review]
Bug 25828: Update cpanfile for 20.05 release cycle

to test...
 1/ check about.pl, see old module versions

 2/ apply patch

 3/ check about.pl, see updated module versions

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2020-06-23 08:17:38 UTC
Changes expected.. Signing off
Comment 5 Jonathan Druart 2020-06-23 08:39:21 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 6 Jonathan Druart 2020-06-23 08:40:48 UTC
backported to 20.05.x for 20.05.01
Comment 7 Aleisha Amohia 2020-06-24 00:35:01 UTC
spoke to Chris, not sure that we should be backporting changes to required module versions without extensive testing. not backported to 19.11.x, unless this can be explained a bit more! :)
Comment 8 Mason James 2020-06-24 07:06:52 UTC
(In reply to Aleisha Amohia from comment #7)
> spoke to Chris, not sure that we should be backporting changes to required
> module versions without extensive testing. not backported to 19.11.x, unless
> this can be explained a bit more! :)

hmm, after a bit more thought - i think this patch is not required
the updated versions are only required for debian packages, not cpan modules

Koha should still work with the following cpan modules...

-requires 'JSON::Validator', '0.97';
-requires 'Mojolicious', '7.21';
-requires 'Mojolicious::Plugin::OpenAPI', '1.15';
-requires 'YAML', '0.71';


Martin, Jonathan, can you please revert the patch from the master and 20.05 branches
Comment 9 Jonathan Druart 2020-06-24 09:39:38 UTC
Reverted from master and 20.05.x (removed from the 20.05.01 package, and will be effective in git for 20.05.02).