Bug 25835 - Include overdue report (under circulation module) as a staff permission
Summary: Include overdue report (under circulation module) as a staff permission
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Andrew Fuerste-Henry
QA Contact: Testopia
URL:
Keywords: release-notes-needed
Depends on:
Blocks:
 
Reported: 2020-06-21 18:08 UTC by Kelly McElligott
Modified: 2024-01-19 22:39 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08


Attachments
Bug 25835: Include overdues with fines in overdues_report permission (3.82 KB, patch)
2023-11-29 18:06 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 25835: Include overdues with fines in overdues_report permission (3.87 KB, patch)
2023-11-29 18:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 25835: Include overdues with fines in overdues_report permission (3.93 KB, patch)
2024-01-05 20:22 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2020-06-21 18:08:32 UTC
Currently, when setting up permission for staff, the report for Overdue reports portion of the Circulation module, is only partially included in staff permission.  There is a permission that allows staff to run the Overdue report )Execute overdue items report (overdues_report)) - but this does prohibit the Overdue report from displaying on circulation page, but the Overdue with Fines does display.  It would more helpful, if this permission included both reports or add another permission to allow libraries to include/exclude this other report.
Comment 1 Andrew Fuerste-Henry 2023-11-28 19:03:03 UTC
I'm ruling this a bug rather than an enhancement. Either the existing permission should be renamed to reflect its limited scope, or its scope should be expanded to include the Overdues With Fines report.
Comment 2 Andrew Fuerste-Henry 2023-11-29 18:06:53 UTC
Created attachment 159363 [details] [review]
Bug 25835: Include overdues with fines in overdues_report permission

To test:
1 - have a user with circulate_remaining_permissions but not overdues_report
2 - confirm user can see and run Overdues with Fines
3 - apply patch
4 - confirm user can no longer see links to Overdues with Fines or load the page directly by entering the url
5 - confirm a user with overdues_report or greate permission can see and use the tool
Comment 3 Owen Leonard 2023-11-29 18:32:38 UTC
Created attachment 159364 [details] [review]
Bug 25835: Include overdues with fines in overdues_report permission

To test:
1 - have a user with circulate_remaining_permissions but not
    overdues_report
2 - confirm user can see and run Overdues with Fines
3 - apply patch
4 - confirm user can no longer see links to Overdues with Fines or load
    the page directly by entering the url
5 - confirm a user with overdues_report or greate permission can see and
    use the tool

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Nick Clemens (kidclamp) 2024-01-05 20:22:20 UTC
Created attachment 160592 [details] [review]
Bug 25835: Include overdues with fines in overdues_report permission

To test:
1 - have a user with circulate_remaining_permissions but not
    overdues_report
2 - confirm user can see and run Overdues with Fines
3 - apply patch
4 - confirm user can no longer see links to Overdues with Fines or load
    the page directly by entering the url
5 - confirm a user with overdues_report or greate permission can see and
    use the tool

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-01-11 14:49:43 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-15 14:18:34 UTC
Pushed to 23.11.x for 23.11.02
Comment 7 Lucas Gass 2024-01-19 22:39:26 UTC
Backported to 23.05.x for upcoming 23.05.08