When looking at the list of holds on request.pl, it's not terribly obvious when a hold is suspended. It'd be great to make that line appear in a different color or something else immediately obvious.
Created attachment 148283 [details] [review] Bug 25856: Add suspend class to tr's of suspended holds To test: 1. Apply patch. 2. Place multiple holds on a record and then go suspend some of them. 3. Those suspended holds should now have a class of 'suspended' 4. Now you can add any kind of CSS you want to make those rows stand out. You can try adding this to IntranetUSerCSS: .suspend > td { color: red; }
This patch also fixes a case of <th> which should be <td>
Created attachment 148291 [details] [review] Bug 25856: Add suspend class to tr's of suspended holds To test: 1. Apply patch. 2. Place multiple holds on a record and then go suspend some of them. 3. Those suspended holds should now have a class of 'suspended' 4. Now you can add any kind of CSS you want to make those rows stand out. You can try adding this to IntranetUSerCSS: .suspend > td { color: red; } Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
This worked as expected. When I used the CSS suggested in the test plan it only changed the text color in the date and details columns which did not seem like enough of a change/indication that the item is suspended. I was able to use background-color instead and that made the suspended item stand out much more.
(In reply to Barbara Johnson from comment #4) > This worked as expected. When I used the CSS suggested in the test plan it > only changed the text color in the date and details columns which did not > seem like enough of a change/indication that the item is suspended. I was > able to use background-color instead and that made the suspended item stand > out much more. Thanks for testing. My idea was to just use a class name on the suspended rows and that allows libraries to customize this in any way they choose.
Created attachment 148327 [details] [review] Bug 25856: Add suspend class to tr's of suspended holds To test: 1. Apply patch. 2. Place multiple holds on a record and then go suspend some of them. 3. Those suspended holds should now have a class of 'suspended' 4. Now you can add any kind of CSS you want to make those rows stand out. You can try adding this to IntranetUSerCSS: .suspend > td { color: red; } Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Enhancement - not backporting to 22.11.x Nice work everyone!