Created attachment 106311 [details] Screenshot showing the guarantor section of the patron add form I noticed that the soft blue border that surrounds a guarantor's information in the patron form is slightly larger than the containing box. To reproduce: 1- Add a patron 2- In guarantor information, search for and add a guarantor 3- Notice that the border surrounding the guarantor is larger than the box for guarantor information
Created attachment 106638 [details] [review] Bug 25879: Improve display of guarantor information in the patron entry form This patch makes some changes to the patron entry template to improve the display of guarantor information. To test, apply the patch and locate a patron with a "Child" type category. - Edit the patron's record - Under "Guarantor information," click the "Search to add" button. - Search for and select a patron. - The guarantor information should be added to the patron edit form. The information should be correct and well formatted. - Click the "Remove" link. The guarantor information should be removed. - Search for an select a guarantor again and save the record. - Edit the patron record again. The saved guarantor information should look correct.
Created attachment 106669 [details] [review] Bug 25879: Improve display of guarantor information in the patron entry form This patch makes some changes to the patron entry template to improve the display of guarantor information. To test, apply the patch and locate a patron with a "Child" type category. - Edit the patron's record - Under "Guarantor information," click the "Search to add" button. - Search for and select a patron. - The guarantor information should be added to the patron edit form. The information should be correct and well formatted. - Click the "Remove" link. The guarantor information should be removed. - Search for an select a guarantor again and save the record. - Edit the patron record again. The saved guarantor information should look correct. Looks great! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
This looks good Owen, but if I start from an adult patron and click 'Add guarantee' I still get the problem in the initial comment
Created attachment 107973 [details] [review] Bug 25879: (follow-up) Update overlooked guarantor markup This patch updates another section of guarantor markup which should have been updated with the others. To test, apply the patch and locate an adult patron. - Click "Add guarantee" - Confirm that the part of the form for adding a guarantee looks correct. - Confirm that the new patron information is saved correctly.
Created attachment 108012 [details] [review] Bug 25879: Improve display of guarantor information in the patron entry form This patch makes some changes to the patron entry template to improve the display of guarantor information. To test, apply the patch and locate a patron with a "Child" type category. - Edit the patron's record - Under "Guarantor information," click the "Search to add" button. - Search for and select a patron. - The guarantor information should be added to the patron edit form. The information should be correct and well formatted. - Click the "Remove" link. The guarantor information should be removed. - Search for an select a guarantor again and save the record. - Edit the patron record again. The saved guarantor information should look correct. Looks great! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 108013 [details] [review] Bug 25879: (follow-up) Update overlooked guarantor markup This patch updates another section of guarantor markup which should have been updated with the others. To test, apply the patch and locate an adult patron. - Click "Add guarantee" - Confirm that the part of the form for adding a guarantee looks correct. - Confirm that the new patron information is saved correctly. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x