I noticed the 'Desks' link in the administration menu on the left side is displayed even if the UseCirculationDesks syspref is turned off. To reproduce: 1- Make sure UseCirculationDesks is set to 'Don't use' 2- Go in Administration > Libraries (or any other section of the admin module) 3- Notice the 'Desks' link in the left side menu
Actually, I just turned on the syspref and 'Desks' still does not appear on my main administration page... Maybe it's just my installation that's buggy.
Created attachment 107057 [details] [review] Bug 25919: Only show Desks in admin navigation when UseCirculationDesks is used We were missing a check for the UseCirculationDesks in the template so the "Desks" link would only appear in the admin navigation when the pref feature is activated. To test: - Turn off UseCirculationDesks - Go to any administration page that shows the navigation on the left - Verify Desks shows - Apply patch - Reload the admin page - Desks should be gone - Turn on UseCirculationDesks - Verify the Desks reappear
Created attachment 107433 [details] [review] Bug 25919: Only show Desks in admin navigation when UseCirculationDesks is used We were missing a check for the UseCirculationDesks in the template so the "Desks" link would only appear in the admin navigation when the pref feature is activated. To test: - Turn off UseCirculationDesks - Go to any administration page that shows the navigation on the left - Verify Desks shows - Apply patch - Reload the admin page - Desks should be gone - Turn on UseCirculationDesks - Verify the Desks reappear Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 107937 [details] [review] Bug 25919: Only show Desks in admin navigation when UseCirculationDesks is used We were missing a check for the UseCirculationDesks in the template so the "Desks" link would only appear in the admin navigation when the pref feature is activated. To test: - Turn off UseCirculationDesks - Go to any administration page that shows the navigation on the left - Verify Desks shows - Apply patch - Reload the admin page - Desks should be gone - Turn on UseCirculationDesks - Verify the Desks reappear Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Works as described. One question: even after this I can access the page and define desks if the syspref is disabled - should we block this too?
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.03
UseCirculationDesks not in 19.11.x, not backported
For the sake of the release notes, I'm marking this as a bug rather than an enhancement, as it does not add/modify any functionality. Feel free to change it back if you are opposed to it.