Bug 24886 cleaned up the templates and removed a new line in the recordnumber_list textarea loop Now if one tries to send biblionumbers from a report to batch operations they are all sent as a single string
Cardnumbers do the same. Itemnumbers do not.
This bug completely breaks a relatively new and rather popular feature. It'd be great to see it fixed sooner rather than later.
+1
Created attachment 113782 [details] [review] Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblios 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work!
Created attachment 113783 [details] [review] Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblios 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 113916 [details] [review] Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblio 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
As a step towards QA, here is another signoff. However, the QA script reports this: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt FAIL filters missing_filter at line 873 ( [%- recordnumbers = PROCESS batch_list results=results batch_type='biblionumber' | trim %][% IF recordnumbers %][% SET batch_biblionumbers = 1 %][% recordnumbers %][% END -%]) missing_filter at line 873 ( [%- recordnumbers = PROCESS batch_list results=results batch_type='biblionumber' | trim %][% IF recordnumbers %][% SET batch_biblionumbers = 1 %][% recordnumbers %][% END -%]) missing_filter at line 882 ( [%- recordnumbers = PROCESS batch_list results=results batch_type='biblionumber' | trim %][% IF recordnumbers %][% SET batch_biblionumbers = 1 %][% recordnumbers %][% END -%]) missing_filter at line 882 ( [%- recordnumbers = PROCESS batch_list results=results batch_type='biblionumber' | trim %][% IF recordnumbers %][% SET batch_biblionumbers = 1 %][% recordnumbers %][% END -%]) missing_filter at line 935 ( [%- cardnumbers = PROCESS batch_list results=results batch_type='cardnumber' | trim %][% IF cardnumbers %][% SET batch_cardnumbers = 1 %][% cardnumbers %][% END -%]) missing_filter at line 935 ( [%- cardnumbers = PROCESS batch_list results=results batch_type='cardnumber' | trim %][% IF cardnumbers %][% SET batch_cardnumbers = 1 %][% cardnumbers %][% END -%])
Created attachment 113924 [details] [review] Bug 25942: (follow-up) fix filters
Created attachment 113931 [details] [review] Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblio 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 113932 [details] [review] Bug 25942: (follow-up) fix filters Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Thanks, QA script ok :)
(and it works ^^)
Created attachment 113972 [details] [review] Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblio 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Bug 25942: (follow-up) fix filters Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 20.11, thanks to everybody involved!
This doesn't seem to have correctly addressed batch patron modifications: Bug 27142
Any chance at a backport to 20.05?
backported to 20.05.x for 20.05.07
Missing dependencies for 19.11.x, no backport. 19.11.x shouldn't be affected.
*** Bug 27902 has been marked as a duplicate of this bug. ***