Bug 25949 - Date and time displaying AM when it should show PM
Summary: Date and time displaying AM when it should show PM
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-08 05:24 UTC by David Cook
Modified: 2021-06-14 21:28 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2020-07-08 05:24:33 UTC
When TimeFormat is 12 hours, 07/08/2020 03:23 AM is being shown instead of 07/08/2020 03:23 PM.

At a glance, it's because we use output_pref both in about.pl and about.tt and it's getting confused.
Comment 1 David Cook 2020-07-08 05:24:54 UTC
Note so far I've only tested this with an undefined timezone but I doubt it's relevant
Comment 2 David Cook 2020-07-08 05:36:34 UTC
I tried to reproduce this in koha-testing-docker but I couldn't...

I'm just noticing it on normal 19.11 instances...

From a code perspective, they look the same. I have no idea why this is only happening on Debian Stretch with 19.11 and OpenSuse with 19.11. 

But I guess for now I'll just close it

Test Plan:

1. Set TimeFormat to "12 hour format"
2. Set timezone in koha-conf.xml to a timezone that should be currently in the PM
3. restart_all (in koha-testing-docker)