Bug 25995 - Log changes to due date using bulk edit tool in circulation log
Summary: Log changes to due date using bulk edit tool in circulation log
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 24846
Blocks:
  Show dependency treegraph
 
Reported: 2020-07-15 18:34 UTC by Andrew Fuerste-Henry
Modified: 2022-04-13 12:36 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 25995: Log RENEWAL when "extend due dates" tool is used (1.67 KB, patch)
2020-07-27 11:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 25995: Remove existing CATALOGUING/MODIFY log (1.01 KB, patch)
2020-07-29 07:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 25995: Log CIRCULATION+MODIFYwhen "extend due dates" tool is used (1.74 KB, patch)
2020-07-29 13:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 25995: Remove existing CATALOGUING/MODIFY log (1.01 KB, patch)
2020-07-29 13:30 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2020-07-15 18:34:35 UTC
The bulk edit due date tool from bug 24846 doesn't log that change in the circ log. That leaves us without a way to report on how many due dates were changed and creates a really big uncertainty in troubleshooting checkouts with weird due dates.
Comment 1 Jonathan Druart 2020-07-27 11:05:53 UTC
Created attachment 107411 [details] [review]
Bug 25995: Log RENEWAL when "extend due dates" tool is used

RENEWAL logs are created when an issue is renewed from the circulation
module. We should log as well when the "extend due dates" tool is used
to renew issues.

Test plan:
Turn on RenewalLog
Create an issue
Renew it using the "extend due dates"
Confirm that the log has been created
Comment 2 Andrew Fuerste-Henry 2020-07-27 12:32:09 UTC
A change with the extend due dates tool isn't strictly a renewal and doesn't count as one when calculating renewals allowed. Seems like it could get confusing to log it as such. If we don't want to go as far as introducing a new type of action, I think it might make more sense to record these as "Modify."
Comment 3 Jonathan Druart 2020-07-27 13:19:39 UTC
There is a "modify item" log that is created already.
Comment 4 Katrin Fischer 2020-07-27 19:21:19 UTC
I think Action modify + module circulation would be a good fit. We are not changing the item, but an issue - that would make it clear and reuse existing values.
Comment 5 Andrew Fuerste-Henry 2020-07-28 14:45:22 UTC
I saw that this change to due date is currently recorded in the cataloging log as a modification to the item, yes. That's helpful at the moment, while we're not otherwise logging this. But we have a lot of libraries that don't use the cataloging log due to its size.

We pointedly removed all other circ-related item changes from the cataloging log. Should this change be excluded from the cataloging log, too?
Comment 6 Jonathan Druart 2020-07-29 07:42:02 UTC
Created attachment 107476 [details] [review]
Bug 25995: Remove existing CATALOGUING/MODIFY log

We had a log when the item was modified. We previously removed such
cataloguing log from circulation (bug 18816)
Comment 7 Jonathan Druart 2020-07-29 07:42:39 UTC
Is this patch correct? I am not sure I understand Katrin's comment (comment #4).
Comment 8 Katrin Fischer 2020-07-29 07:49:22 UTC
I was suggesting to log it as MODIFY instead of RENEWAL within the circulation logs, so we can tell them apart. As Andrew points out it's not a regular renewal but a forced change of date.
Comment 9 Jonathan Druart 2020-07-29 08:28:33 UTC
a new "BATCH_RENEWAL" then?
Comment 10 Andrew Fuerste-Henry 2020-07-29 12:03:01 UTC
I'd prefer to avoid the term "renewal" entirely, since this is not a renewal and doesn't count against the patron's count of renewals allowed. It's a minor distinction, but one I expect could be a source of confusion for users.
Comment 11 Jonathan Druart 2020-07-29 12:49:06 UTC
circulation+modify then?
Comment 12 Andrew Fuerste-Henry 2020-07-29 13:03:44 UTC
(In reply to Jonathan Druart from comment #11)
> circulation+modify then?

Seems like the best option to me!
Comment 13 Jonathan Druart 2020-07-29 13:30:44 UTC
Created attachment 107499 [details] [review]
Bug 25995: Log CIRCULATION+MODIFYwhen "extend due dates" tool is used

RENEWAL logs are created when an issue is renewed from the circulation
module. We should log as well when the "extend due dates" tool is used
to renew issues. As they are not proper renewals, CIRCULATION+MODIFY
will be used.

Test plan:
Turn on RenewalLog
Create an issue
Renew it using the "extend due dates"
Confirm that the log has been created
Comment 14 Jonathan Druart 2020-07-29 13:30:48 UTC
Created attachment 107500 [details] [review]
Bug 25995: Remove existing CATALOGUING/MODIFY log

We had a log when the item was modified. We previously removed such
cataloguing log from circulation (bug 18816)
Comment 15 Jonathan Druart 2020-07-29 13:31:48 UTC
Patches updated, a CIRCULATION+MODIFY log is now created if RenewalLog is set.
Not sure it's what we want however.
Comment 16 Andrew Fuerste-Henry 2020-08-03 14:10:31 UTC
The more I think about this, I'd like to see this logged regardless of the renewal log. Because this tool changes due dates in a manner wholly outside the circ rules, we've seen a lot of confusion when its use isn't well documented. As such, I think we should always log it.
Comment 17 Katrin Fischer 2020-08-05 11:39:19 UTC
Hm, I think as the logs contain 'personal data', we should maintain the ability to decide not to keep logs for the libraries. But I think RenwalLog might not be the right one. What about using Issuelog instead, which matches our change to "CIRCULATION" and add the case to the pref description?
Comment 18 Jonathan Druart 2020-08-05 12:34:45 UTC
What about a new "tools" module for logs?
Comment 19 Katrin Fischer 2020-08-05 14:47:43 UTC
Hm, that could work. Andrew, what do you think?
Comment 20 Andrew Fuerste-Henry 2020-08-05 15:01:45 UTC
Good point about being able to opt out of logging personal data. I think a new Tools Log module and corresponding syspref is reasonable.
If we're establishing a new module, what data do we write into the log? How about object = issue_id, info = new due date?
Recording the issue_id rather the borrowernumber breaks the tie back to the patron, if they're anonymizing their reading history.