That's a good point, although that could be dangerous to automate for libraries with large collections. You don't want to be doing that every week to 1,000,000+ records. Even doing it 1 time during the upgrade could be dangerous, as it could make an upgrade last for many hours.

This is another one of those instances where a temporary pop-up post-upgrade reminding people to run a cleanup job wouldn't be a bad idea.

I'd be anti-automation in this case, since this is a job that should be deliberately planned by a human.

Thank you, David. Wasn't sure how resource-intensive that process might be. Pop-up and/or reminder would certainly do the trick.

Cheers,

Cab

(In reply to Cab Vinton from comment #2)
> Thank you, David. Wasn't sure how resource-intensive that process might be.
> Pop-up and/or reminder would certainly do the trick.

Unfortunately, I don't know the best way of doing a pop-up and/or reminder. Tomas has mentioned that Koha has done that one or two times before, but I haven't investigated yet.

Above my pay grade as well, David, but easy enough to at least modify the text on that page.

Cab, which exact text would you like to be displayed?

Created attachment 109301 [details] [review]
Bug 26007: Add/fix warning for changes to the Koha to MARC mappings

There are 2 pages where one can change the Koha to MARC mappings in Koha:

- When editing the configuration for a MARC subfield
- On administration > Koha 2 MARC mappings

This patch adds a warning that the batchRebuildBiblioTables script
must be run if the mapping is changed.

To test:
- Go to Administration > MARC bibliographic frameworks >
  Any framework > MARC structure > Any field > Edit subfield
- ÃThe hint about the batchRebuildBiblioTables will be on "Link"
  instead of "Koha Link". This is wrong as the link doesn't care
  about the mappings.
- Go to Administration > Koha to MARC mappings
- Verify there is no hint
- Apply patch
- Verify both pages now show an appropriate message

Created attachment 109302 [details] [review]
Bug 26007: Add/fix warning for changes to the Koha to MARC mappings

There are 2 pages where one can change the Koha to MARC mappings in Koha:

- When editing the configuration for a MARC subfield
- On administration > Koha 2 MARC mappings

This patch adds a warning that the batchRebuildBiblioTables script
must be run if the mapping is changed.

To test:
- Go to Administration > MARC bibliographic frameworks >
  Any framework > MARC structure > Any field > Edit subfield
- ÃThe hint about the batchRebuildBiblioTables will be on "Link"
  instead of "Koha Link". This is wrong as the link doesn't care
  about the mappings.
- Go to Administration > Koha to MARC mappings
- Verify there is no hint
- Apply patch
- Verify both pages now show an appropriate message

I've also submitted a merge request to the manual to clean up and correct the information about Link and Koha link:
https://gitlab.com/koha-community/koha-manual/-/merge_requests/390

Created attachment 109638 [details] [review]
Bug 26007: Add/fix warning for changes to the Koha to MARC mappings

There are 2 pages where one can change the Koha to MARC mappings in Koha:

- When editing the configuration for a MARC subfield
- On administration > Koha 2 MARC mappings

This patch adds a warning that the batchRebuildBiblioTables script
must be run if the mapping is changed.

To test:
- Go to Administration > MARC bibliographic frameworks >
  Any framework > MARC structure > Any field > Edit subfield
- The hint about the batchRebuildBiblioTables will be on "Link"
  instead of "Koha Link". This is wrong as the link doesn't care
  about the mappings.
- Go to Administration > Koha to MARC mappings
- Verify there is no hint
- Apply patch
- Verify both pages now show an appropriate message

Signed-off-by: David Nind <david@davidnind.com>

(In reply to Katrin Fischer from comment #8)
> I've also submitted a merge request to the manual to clean up and correct
> the information about Link and Koha link:
> https://gitlab.com/koha-community/koha-manual/-/merge_requests/390

Caroline has merged the excellent manual changes!

Thx David and Caroline!

QAing

The manual here needs some attention too !

Link

    If you enter a field/subfield here (200b), a link appears after the subfield in the MARC Detail view. This view is present only in the staff client, not the OPAC. If the librarian clicks on the link, a search is done on the database for the field/subfield with the same value. This can be used for 2 main topics :

        on a field like author (200f in UNIMARC), put 200f here, you will be able to see all bib records with the same author.

        on a field that is a link (4xx) to reach another bib record. For example, put 011a in 464$x, will find the serials that are with this ISSN.

    Warning

        This value should not change after data has been added to your catalog. If you need to change this value you must ask your system administrator to run misc/batchRebuildBiblioTables.pl.

Koha link

    Koha is multi-MARC compliant. So, it does not know what the 245$a means, neither what 200$f (those 2 fields being both the title in MARC21 and UNIMARC). So, in this list you can “map” a MARC subfield to its meaning. Koha constantly maintains consistency between a subfield and its meaning. When the user wants to search on “title”, this link is used to find what is searched (245 if you’re MARC21, 200 if you’re UNIMARC).

The manual tells you to insert things like 200f which really should be search index.

Should we also refer to misc/batchRebuildItemsTables.pl on the Koha to MARC mappings page? Scroll to the bottom, you can also change mappings on items.

Created attachment 109649 [details] [review]
Bug 26007: Add/fix warning for changes to the Koha to MARC mappings

There are 2 pages where one can change the Koha to MARC mappings in Koha:

- When editing the configuration for a MARC subfield
- On administration > Koha 2 MARC mappings

This patch adds a warning that the batchRebuildBiblioTables script
must be run if the mapping is changed.

To test:
- Go to Administration > MARC bibliographic frameworks >
  Any framework > MARC structure > Any field > Edit subfield
- ÃThe hint about the batchRebuildBiblioTables will be on "Link"
  instead of "Koha Link". This is wrong as the link doesn't care
  about the mappings.
- Go to Administration > Koha to MARC mappings
- Verify there is no hint
- Apply patch
- Verify both pages now show an appropriate message

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This commit message is not completely accurate. See the follow-ups.

Created attachment 109650 [details] [review]
Bug 26007: (QA follow-up) Add index name to the q parameter

The link constructed in MARC-detail is not consistent. It adds
an index name but does not show in the query in the search box.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Created attachment 109651 [details] [review]
Bug 26007: (QA follow-up) Replace wrong link values from sql installer files

Field 943$a has link value "130". This does not work; 130 is not a search
index. It should be Title-uniform.
Note: Only used on a search link in the intranet MARC detail page.

In some cases "130" should be replaced by "Title-uniform", but sometimes
130 without quotes had to be replaced. Performed by two sed statements
on git grep results.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Created attachment 109652 [details] [review]
Bug 26007: (QA follow-up) Remove message on marc_subfields_structure

Why? Since the combo has been disabled since a few releases. If you
want to change this mapping, you should do it on Koha to MARC mappings.
This change is no longer per framework, but over all frameworks.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

(In reply to Marcel de Rooy from comment #13)
> The manual here needs some attention too !
> 
> Link
> 
>     If you enter a field/subfield here (200b), a link appears after the
> subfield in the MARC Detail view. This view is present only in the staff
> client, not the OPAC. If the librarian clicks on the link, a search is done
> on the database for the field/subfield with the same value. This can be used
> for 2 main topics :

Hi Marcel, I agree - that's why I patched it (see gitlab link above) ;)

There currently doesn't appear to be a preview for the master manual, but you can see the changes applied now it git:
https://gitlab.com/koha-community/koha-manual/-/commit/73660a674aaa3431ec9eac09f8fb1e38d2fafaf6

I agree with your last follow-up, but we should stop displaying this as a non-functional pull-down on the configuration page then - it fooled me.

Bug 26007: (QA follow-up) Replace wrong link values from sql installer files is missing updates to the .yml files for the en and es-ES based installers. I think this would have been better as a separate bug.

(In reply to Katrin Fischer from comment #20)
> (In reply to Marcel de Rooy from comment #13)

> I agree with your last follow-up, but we should stop displaying this as a
> non-functional pull-down on the configuration page then - it fooled me.

Yeah, please remove it on a new report.

> Bug 26007: (QA follow-up) Replace wrong link values from sql installer files
> is missing updates to the .yml files for the en and es-ES based installers.
> I think this would have been better as a separate bug.

If you prefer, feel free to move this patch to a new report. Could you sign off?

Pushed to master for 20.11, thanks to everybody involved!

We need a follow-up here still for the .yml en files.

(In reply to Katrin Fischer from comment #23)
> We need a follow-up here still for the .yml en files.

Will add a patch. I remember that I did change it, but I may have changed my sed statements later on and it fell out of the selection due to its new formatting somehow.

Created attachment 109881 [details] [review]
Bug 26007: (QA follow-up) Fix English yml file

git grep -l -E "link:\s*\"?[0-9]" | xargs sed -i -e "/link:/ s/130/\"Title-uniform\"/"
Only one occurrence without quotes around 130.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

@RM: Please push last patch only.

Last patch pushed to master.

backported to 20.05.x for 20.05.04

enhancement, not backported to 19.11.x