As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should replaced in the OPAC cart, for handling checkbox actions like "select all" and "clear all." The plugin is very old and unmaintained. We should use our own JS to replace it.
Created attachment 107024 [details] [review] Bug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart This patch removes the use of the jquery.checkboxes plugin from the OPAC cart and replaces its functionality with "plain" jQuery. To test, apply the patch and add some items to the Cart in the OPAC. - Open the Cart window in the OPAC by clicking the "Cart" link in the header. - Test that the "Select all" and "Clear all" links work correctly to check and uncheck all checkboxes. - Controls like "Remove" and "Place hold" should be enabled or disabled according to whether there are any checked checkboxes. - Test that manually checking a checkbox correctly enables or disables the link options too. - Test that the "Remove" or "Place hold" controls work correctly, applying to only the checked checkboxes.
Created attachment 107648 [details] [review] Bug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart This patch removes the use of the jquery.checkboxes plugin from the OPAC cart and replaces its functionality with "plain" jQuery. To test, apply the patch and add some items to the Cart in the OPAC. - Open the Cart window in the OPAC by clicking the "Cart" link in the header. - Test that the "Select all" and "Clear all" links work correctly to check and uncheck all checkboxes. - Controls like "Remove" and "Place hold" should be enabled or disabled according to whether there are any checked checkboxes. - Test that manually checking a checkbox correctly enables or disables the link options too. - Test that the "Remove" or "Place hold" controls work correctly, applying to only the checked checkboxes. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 108020 [details] [review] Bug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart This patch removes the use of the jquery.checkboxes plugin from the OPAC cart and replaces its functionality with "plain" jQuery. To test, apply the patch and add some items to the Cart in the OPAC. - Open the Cart window in the OPAC by clicking the "Cart" link in the header. - Test that the "Select all" and "Clear all" links work correctly to check and uncheck all checkboxes. - Controls like "Remove" and "Place hold" should be enabled or disabled according to whether there are any checked checkboxes. - Test that manually checking a checkbox correctly enables or disables the link options too. - Test that the "Remove" or "Place hold" controls work correctly, applying to only the checked checkboxes. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Should not we remove the checkboxed class on the 2 forms of opac-basket.tt?
Created attachment 108154 [details] [review] (follow-up) Removed checkboxed class Bug 26008: (follow-up) Removed checkboxed class This patch removes the "checkboxed" class which was previously associated with the jquery.checkboxes plugin and is now obsolete.
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x. for 20.05.03 I did not see the commit for the follow up in master, has that been pushed yet?
I've squashed them.
enhancement, not backported to 19.11.x