Master_U20 #41 15:40:07 koha_1 | # Failed test 'Test ModReserveMinusPriority()' 15:40:07 koha_1 | # at t/db_dependent/Holds.t line 202. 15:40:07 koha_1 | # got: undef 15:40:07 koha_1 | # expected: '1605' 15:40:48 koha_1 | # Looks like you failed 1 test of 66. 15:40:48 koha_1 | [13:40:48] t/db_dependent/Holds.t Already reported on bug 24657 comment 4.
Created attachment 107178 [details] [review] Bug 26043: Fix random failure from Holds.t # Failed test 'Test ModReserveMinusPriority()' # at t/db_dependent/Holds.t line 202. # got: undef # expected: '1605' # Looks like you failed 1 test of 66. It is coming from Koha::Patron->holds that is ordering by reservedate, so "sometimes" they are ordered in reverse (at least it's my understanding of the problem). Test plan: Run the test file several times (from 20 to 60x), it must never fail with this patch
Created attachment 107829 [details] [review] Bug 26043: Fix random failure from Holds.t # Failed test 'Test ModReserveMinusPriority()' # at t/db_dependent/Holds.t line 202. # got: undef # expected: '1605' # Looks like you failed 1 test of 66. It is coming from Koha::Patron->holds that is ordering by reservedate, so "sometimes" they are ordered in reverse (at least it's my understanding of the problem). Test plan: Run the test file several times (from 20 to 60x), it must never fail with this patch Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Verified the tests is still testing for what it should be with the code update Varified that the tests pass consistently over multiple runs. Code is clear and easy to follow.. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.03
backported to 19.11.x for 19.11.09
Backported to 19.05.x branch for 19.05.15