After Bug 24279 the "Statuses" section on the item detail page (moredetail.pl) isn't formatted correctly. The ordered list no longer has the correct CSS applied because the container changed from <div> to <span>
Created attachment 107534 [details] [review] Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid <br clear="both"/> - Move heading inside container so that floats clear correctly - Change <span> tag back to <div> to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list.
Created attachment 107575 [details] [review] Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid <br clear="both"/> - Move heading inside container so that floats clear correctly - Change <span> tag back to <div> to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list.
Created attachment 107578 [details] [review] Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid <br clear="both"/> - Move heading inside container so that floats clear correctly - Change <span> tag back to <div> to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 107610 [details] [review] Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid <br clear="both"/> - Move heading inside container so that floats clear correctly - Change <span> tag back to <div> to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
missing 20.05.x dependency, no backport