Bug 2616 - unnecessary 'use HTML::Template'
Summary: unnecessary 'use HTML::Template'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Ian Walls
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-17 05:13 UTC by Galen Charlton
Modified: 2013-12-05 19:59 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (2.04 KB, patch)
2011-12-04 17:35 UTC, Ian Walls
Details | Diff | Splinter Review
Signed patch (2.14 KB, patch)
2011-12-05 08:24 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:53:30 UTC


---- Reported by gmcharlt@gmail.com 2008-09-17 05:13:30 ----

A number of Perl scripts have 'use HTML::Template' or 'use HTML::Template::Pro'; except for a few scripts that need to create a template object directly, the module import in C4::Output is sufficient.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:53 UTC  ---

This bug was previously known as _bug_ 2616 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2616

Actual time not defined. Setting to 0.0
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, gmcharlt@gmail.com.
   Previous assignee was david@leals.com.

Comment 1 Owen Leonard 2011-05-18 17:44:28 UTC
This is still true, even after the switch to Template::Toolkit. Is the fix simply to delete the line from all the files where it is found?
Comment 2 Ian Walls 2011-12-04 17:35:08 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2011-12-05 08:24:27 UTC
Created attachment 6574 [details] [review]
Signed patch

Signed off
Comment 4 Marcel de Rooy 2011-12-05 08:26:19 UTC
QA: Updating patch status to Passed QA now too.
Comment 5 Paul Poulain 2011-12-06 10:35:03 UTC
Patch pushed, please test
Comment 6 Jared Camins-Esakov 2012-05-23 12:43:19 UTC
This was included in the 3.6 branch prior to 3.6.4.