From bug 22543 comment30: (In reply to Jonathan Druart from comment #29) > 2. This code has been put before track_login_daily, is that expected? No. The track call should be done before.
Created attachment 108052 [details] [review] Bug 26191: Relocate track_login call in Auth.pm This is a leftover from bug 22543. Trivial move. Test plan: Do not apply this patch. Pick a user that has not yet logged in today. Only login via the opac and immediately check if borrowers.datelastseen did not change. Apply this patch, restart, flush etc. Only login via the opac and verify again rightaway (no further opac actions). Now datelastseen should have been changed already. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Still applies, taking liberty to self signoff before we can also rebase this one liner ;)
Created attachment 111243 [details] [review] Bug 26191: Relocate track_login call in Auth.pm This is a leftover from bug 22543. Trivial move. Test plan: Do not apply this patch. Pick a user that has not yet logged in today. Only login via the opac and immediately check if borrowers.datelastseen did not change. Apply this patch, restart, flush etc. Only login via the opac and verify again rightaway (no further opac actions). Now datelastseen should have been changed already. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Passing QA, patch is clear and simple and works as expected.
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.06
backported to 19.11.x for 19.11.12
Missing dependencies for 19.05.x, shouldn't affect it.