As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the pending offline circulations page.
Created attachment 108282 [details] [review] Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations This patch removes the use of the jquery.checkboxes plugin from the pending offline circulations page, replacing it with in-page JS. Unrelated: The JS-based creation of the "select all" and "clear all" controls has been replaced with HTML links. Labels are added to the results table to make checkbox selection easier. To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0 Generator=koct-firefox GeneratorVersion=0.1 2020-08-14 13:24:21 issue 0109132 33000000093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly.
Created attachment 108284 [details] [review] Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations This patch removes the use of the jquery.checkboxes plugin from the pending offline circulations page, replacing it with in-page JS. Unrelated: The JS-based creation of the "select all" and "clear all" controls has been replaced with HTML links. Labels are added to the results table to make checkbox selection easier. To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0 Generator=koct-firefox GeneratorVersion=0.1 2020-08-14 13:24:21 issue 0109132 33000000093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly.
Created attachment 108413 [details] [review] Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0 Generator=koct-firefox GeneratorVersion=0.1 2020-08-14 13:24:21 issue 0109132 33000000093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly. ------------------------ Tested offline circulation and working find Check all and Uncheck all option.
Hm I tried uploading the file as decribed... but: Can't use an undefined value as an ARRAY reference at /home/vagrant/kohaclone/offline_circ/enqueue_koc.pl line 148 Not sure if that's only me?
Created attachment 108418 [details] [review] Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations This patch removes the use of the jquery.checkboxes plugin from the pending offline circulations page, replacing it with in-page JS. Unrelated: The JS-based creation of the "select all" and "clear all" controls has been replaced with HTML links. Labels are added to the results table to make checkbox selection easier. To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0 Generator=koct-firefox GeneratorVersion=0.1 2020-08-14 13:24:21 issue 0109132 33000000093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created my transactions using the plugin instead - the checkboxes behave nicely.
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.04
enhancement, not backported to 19.11.x