As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the late orders page.
Created attachment 108287 [details] [review] Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page This patch replaces the use of the jquery.checkboxes plugin on late orders page in acquisitions. Unrelated changes: The "Check all" and "Uncheck all" links are moved out of the table header so that it matches similar interfaces. Sorting is now disabled on the checkboxes column and the table is sorted by default on the "Order line" column. To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number.
Created attachment 108288 [details] [review] Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page This patch replaces the use of the jquery.checkboxes plugin on late orders page in acquisitions. Unrelated changes: The "Check all" and "Uncheck all" links are moved out of the table header so that it matches similar interfaces. Sorting is now disabled on the checkboxes column and the table is sorted by default on the "Order line" column. To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number.
Created attachment 108409 [details] [review] Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number.
Created attachment 108421 [details] [review] Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page This patch replaces the use of the jquery.checkboxes plugin on late orders page in acquisitions. Unrelated changes: The "Check all" and "Uncheck all" links are moved out of the table header so that it matches similar interfaces. Sorting is now disabled on the checkboxes column and the table is sorted by default on the "Order line" column. To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.04
enhancement, not backported to 19.11.x