Same as bug 26136, but for the checkin form in the header
Created attachment 108390 [details] [review] Bug 26224: Prevent double submit of header check in form To test: 1 - Browse to Home 1 - In the header bar select the 'Check in' tab 2 - Type a barcode into the box 3 - Hit Enter as many as times as you can 4 - Check the statistics table: SELECT * FROM statistics WHERE itemnumber={itemnumber} AND DATE(datetime)=CURDATE(); 5 - Note you have multiple lines for the same item at the same time 6 - Apply patch 7 - Reload the page 8 - Type the barcode 9 - Press Enter even more fast and more furiously 10 - Check the statistics table 11 - Only one entry, huzzah!
Created attachment 110647 [details] [review] Bug 26224: Prevent double submit of header check in form To test: 1 - Browse to Home 1 - In the header bar select the 'Check in' tab 2 - Type a barcode into the box 3 - Hit Enter as many as times as you can 4 - Check the statistics table: SELECT * FROM statistics WHERE itemnumber={itemnumber} AND DATE(datetime)=CURDATE(); 5 - Note you have multiple lines for the same item at the same time 6 - Apply patch 7 - Reload the page 8 - Type the barcode 9 - Press Enter even more fast and more furiously 10 - Check the statistics table 11 - Only one entry, huzzah! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Just a note I had to clear my cache after applying patch to get the behavior to change.
Created attachment 110691 [details] [review] Bug 26224: Prevent double submit of header check in form To test: 1 - Browse to Home 1 - In the header bar select the 'Check in' tab 2 - Type a barcode into the box 3 - Hit Enter as many as times as you can 4 - Check the statistics table: SELECT * FROM statistics WHERE itemnumber={itemnumber} AND DATE(datetime)=CURDATE(); 5 - Note you have multiple lines for the same item at the same time 6 - Apply patch 7 - Reload the page 8 - Type the barcode 9 - Press Enter even more fast and more furiously 10 - Check the statistics table 11 - Only one entry, huzzah! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.05
backported to 19.11.x for 19.11.11
Backported to 19.05.x branch for 19.05.17