# Failed test 'Doesn't get biblionumber if the biblionumber matches the one passed to the sub.' # at t/db_dependent/XISBN.t line 81. # got: '767' # expected: undef # Looks like you failed 1 test of 5. t/db_dependent/XISBN.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests
Created attachment 108811 [details] [review] Bug 26270: Fix ThingISBN after a change in behaviour This is just a guess! One of our tests is failing since today and we don't modify anything in this area. My guess is that the service is now returning the normalized version of the ISBN
Hypothetical test plan: Create a bib record A with isbn Create a bib record B with the normalized version of the isbn Without this patch, on A you should see B With this patch applied you should not see B (I did not test)
Created attachment 108828 [details] [review] Bug 26270: Fix ThingISBN after a change in behaviour This is just a guess! One of our tests is failing since today and we don't modify anything in this area. My guess is that the service is now returning the normalized version of the ISBN Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I concur with your guess and I can't see that this patch would cause any regressions. Signing off.
prove t/db_dependent/XISBN.t passes with the patch, not sure what else to test?
Created attachment 108874 [details] [review] Bug 26270: Fix ThingISBN after a change in behaviour This is just a guess! One of our tests is failing since today and we don't modify anything in this area. My guess is that the service is now returning the normalized version of the ISBN Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Use of uninitialized value $biblionumber in string ne at /usr/share/koha/C4/XISBN.pm line 111.
Pushed to master for 20.11, thanks to everybody involved!
(In reply to Marcel de Rooy from comment #7) > Use of uninitialized value $biblionumber in string ne at > /usr/share/koha/C4/XISBN.pm line 111. It appeared before this patch.
(In reply to Jonathan Druart from comment #8) > Pushed to master for 20.11, thanks to everybody involved! Ok, no need to look further here ;)
(In reply to Marcel de Rooy from comment #10) > (In reply to Jonathan Druart from comment #8) > > Pushed to master for 20.11, thanks to everybody involved! > > Ok, no need to look further here ;) I wanted to fix the failing test, but I think it would be good to confirm the hypothesis. I did not manage to validate it.
backported to 19.11.x for 19.11.10
backported to 20.05.x for 20.05.04
Backported to 19.05.x branch for 19.05.15