In returns.tt there are a lot of conditionals that can possibility happen when checking in items, many of these have the common class of 'problem'. I would be nice if each one had a unique ID or class name so they could be specifically targeted for audio alerts. Examples: Not for loan status updated. Item is lost, cannot be checked in. And so on.
"I would be nice if each had a unique name" but also "It would be nice"
Wait, I didn't realize I can use jQuery selectors here. So this works: .problem:contains("Not for loan status updated") Marking this as invalid
I'm reopening this because I think a simpler selector would be a good idea. Having an open bug doesn't hurt.
Created attachment 109774 [details] [review] Bug 26280: Add unique class for each problem in returns.tt This patch adds a 2nd unique class to each of the checkin 'problems' 1. Checkin an item with a bad barcode and see the prolem class also has a class called 'badbarcode' 2. Checkin an item that triggers a lotforloan updated via UpdateNotForLoanStatusOnCheckin, notice the class 'nfl_update'. 3. You should also see an updated_from and updated_to class. This should make it easier to target those for audio alerts 4. Checkin an item that triggers an location update and see the class 'location_update' 5. Checkin an item that is not at its permenat location and you should see the class 'ispermenant'. 6. Checkin an item that is not checkout and you should see the class 'notissued' 7. Checkin lost items with BlockReturnOfLostItems set to 'Dont block' and see the class 'itemlost_checkedin' 8 Checkin lost items with BlockReturnOfLostItems set to 'block' and see the class 'itemlost_blocked' 9. Checkin lost items with a fee on the patron's account for that lost item and see the class 'fee_remains'
I think to make it less likely that these classes collide with classes defined elsewhere in Koha they should have a common prefix. "ret_badbarcode" or something like that.
Created attachment 110413 [details] [review] Bug 26280: Add unique class for each problem in returns.tt 1. Checkin an item with a bad barcode and see the prolem class also has a class called 'ret_badbarcode' 2. Checkin an item that triggers a lotforloan updated via UpdateNotForLoanStatusOnCheckin, notice the class 'ret_nflupdate'. 3. You should also see an updated_from and updated_to class. This should make it easier to target those for audio alerts 4. Checkin an item that triggers an location update and see the class 'ret_locationupdate' 5. Checkin an item that is not at its permenat location and you should see the class 'ret_ispermenant'. 6. Checkin an item that is not checkout and you should see the class 'ret_notissued' 7. Checkin lost items with BlockReturnOfLostItems set to 'Dont block' and see the class 'ret_checkedin' 8 Checkin lost items with BlockReturnOfLostItems set to 'block' and see the class 'ret_blocked' 9. Checkin lost items with a fee on the patron's account for that lost item and see the class 'ret_feeremains' 10. Checkin item that is withdrawn and see the class 'ret_withdrawn'
Created attachment 110601 [details] [review] Bug 26280: Add unique class for each problem in returns.tt 1. Checkin an item with a bad barcode and see the prolem class also has a class called 'ret_badbarcode' 2. Checkin an item that triggers a lotforloan updated via UpdateNotForLoanStatusOnCheckin, notice the class 'ret_nflupdate'. 3. You should also see an updated_from and updated_to class. This should make it easier to target those for audio alerts 4. Checkin an item that triggers an location update and see the class 'ret_locationupdate' 5. Checkin an item that is not at its permenat location and you should see the class 'ret_ispermenant'. 6. Checkin an item that is not checkout and you should see the class 'ret_notissued' 7. Checkin lost items with BlockReturnOfLostItems set to 'Dont block' and see the class 'ret_checkedin' 8. Checkin lost items with BlockReturnOfLostItems set to 'block' and see the class 'ret_blocked' 9. Checkin lost items with a fee on the patron's account for that lost item and see the class 'ret_feeremains' 10. Checkin item that is withdrawn and see the class 'ret_withdrawn' Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 110612 [details] [review] Bug 26280: Add unique class for each problem in returns.tt 1. Checkin an item with a bad barcode and see the prolem class also has a class called 'ret_badbarcode' 2. Checkin an item that triggers a lotforloan updated via UpdateNotForLoanStatusOnCheckin, notice the class 'ret_nflupdate'. 3. You should also see an updated_from and updated_to class. This should make it easier to target those for audio alerts 4. Checkin an item that triggers an location update and see the class 'ret_locationupdate' 5. Checkin an item that is not at its permenat location and you should see the class 'ret_ispermenant'. 6. Checkin an item that is not checkout and you should see the class 'ret_notissued' 7. Checkin lost items with BlockReturnOfLostItems set to 'Dont block' and see the class 'ret_checkedin' 8. Checkin lost items with BlockReturnOfLostItems set to 'block' and see the class 'ret_blocked' 9. Checkin lost items with a fee on the patron's account for that lost item and see the class 'ret_feeremains' 10. Checkin item that is withdrawn and see the class 'ret_withdrawn' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x