The dateexpiry has the markup for being hidden, but you can't do it using the PatronSelfModificationBorrowerUnwantedField pref as it's missing in the column list.
Created attachment 109300 [details] [review] Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal While these may not make sense for all patron field preferences, I think it's better to have them in general than to have them missing. To test: - Check the modal for BorrowerMandatoryField system preference - Verify dateenrolled and enrollmentdate are missing - Apply patch - Verify the dates are listed now - Set both to mandatory - Verify that they are indeed mandatory when adding a new patron now
Created attachment 109686 [details] [review] Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal While these may not make sense for all patron field preferences, I think it's better to have them in general than to have them missing. To test: - Check the modal for BorrowerMandatoryField system preference - Verify dateenrolled and dateexpiry fields are missing - Apply patch - Verify the dates are listed now - Set both to mandatory - Verify that they are indeed mandatory when adding a new patron now Signed-off-by: David Nind <david@davidnind.com>
Note: I changed the test plan in the commit message so that it says "dateenrolled and dateexpiry fields" instead of "dateenrolled and enrollmentdate" - it took me a while to figure out why I couldn't find "enrollmentdate". 8-)
(In reply to David Nind from comment #3) > Note: I changed the test plan in the commit message so that it says > "dateenrolled and dateexpiry fields" instead of "dateenrolled and > enrollmentdate" - it took me a while to figure out why I couldn't find > "enrollmentdate". 8-) Oops, thx!
Created attachment 109891 [details] [review] Bug 26283: Add dateexpiry and dateenrolled to new borrower fields modal While these may not make sense for all patron field preferences, I think it's better to have them in general than to have them missing. To test: - Check the modal for BorrowerMandatoryField system preference - Verify dateenrolled and dateexpiry fields are missing - Apply patch - Verify the dates are listed now - Set both to mandatory - Verify that they are indeed mandatory when adding a new patron now Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x