How to reproduce: 1) Create a new biblio with no items 2) Enable syspref viewLabeledMARC, 4) Go to Labeled MARC tab in biblio details page 5) Click Edit -> Delete record and notice nothing happens. Then check with developer tools the Javascript errors and notice "Uncaught ReferenceError: searchid is not defined" Expected result: deletion should work.
Created attachment 109027 [details] [review] Bug 26289: Add missing variable definition to templates This patch adds definition of the missing "searchid" variable to three bibliographic detail pages. The variable is required by several JavaScript functions. To test, apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Perform the same test with the ISBD view and the MARC view.
Created attachment 109130 [details] [review] Bug 26289: Add missing variable definition to templates This patch puts definition of the missing "searchid" variable into an include file to be used by various bibliographic detail pages. The variable is required by several JavaScript functions. To test, apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Perform the same test with the detail view, ISBD view, MARC view, and items view.
Created attachment 109187 [details] [review] Bug 26289: Add missing variable definition to templates To test Apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. ------------ Worked perfectly.
Created attachment 109190 [details] [review] Bug 26289: Add missing variable definition to templates This patch puts definition of the missing "searchid" variable into an include file to be used by various bibliographic detail pages. The variable is required by several JavaScript functions. To test, apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Perform the same test with the detail view, ISBD view, MARC view, and items view. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
doesnt apply clean to 20.05.x, no backport