Bug 26325 - Add primary_key_exists function to Installer.pm
Summary: Add primary_key_exists function to Installer.pm
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 26326
  Show dependency tree / graph
 
Reported: 2020-08-31 16:43 UTC by Nick Clemens (kidclamp)
Modified: 2021-06-14 21:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00
Circulation function:

Attachments
Bug 26325: Add primary_key_exists check to C4::Installer (2.10 KB, patch)
2020-08-31 16:44 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 26325: Add primary_key_exists check to C4::Installer (2.15 KB, patch)
2020-09-15 15:57 UTC, Brandon J 		Details | Diff | Splinter Review
Bug 26325: Add primary_key_exists check to C4::Installer (2.21 KB, patch)
2020-09-15 20:09 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2020-08-31 16:43:34 UTC 
Some tables don't have a primary key - for atomic update purposes it would be nice to be able to test this
Comment 1 Nick Clemens (kidclamp) 2020-08-31 16:44:59 UTC 
Created attachment 109372 [details] [review]
Bug 26325: Add primary_key_exists check to C4::Installer

To test:
1 - prove -v t/db_dependent/Installer.t
Comment 2 Brandon J 2020-09-15 15:57:45 UTC 
Created attachment 110114 [details] [review]
Bug 26325: Add primary_key_exists check to C4::Installer

To test:
1 - prove -v t/db_dependent/Installer.t

Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>
Comment 3 Katrin Fischer 2020-09-15 20:09:09 UTC 
Created attachment 110124 [details] [review]
Bug 26325: Add primary_key_exists check to C4::Installer

To test:
1 - prove -v t/db_dependent/Installer.t

Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2020-10-01 09:45:25 UTC 
Pushed to master for 20.11, thanks to everybody involved!
Comment 5 Lucas Gass (lukeg) 2020-10-20 17:35:21 UTC 
enhancement will not be backported to 20.05.x