Created attachment 109386 [details] Screenshot of the issue To describe items with more detail a librarian needed more subfields on 952 tag, so after using the few available ASCII letters and numbers started using Greek letters, alpha (α), beta (β), gamma (γ)... Then while editing any subfield, currently selected is shown and then all the other new ones (full-page screenshot attached). The problem seems related to the fact that under subfieldtabs id all divs but the selected should have style="display: none;". This is working only with all the ones matching [0-9a-z].
Created attachment 109422 [details] [review] Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints This patch changes the encoding of the data being used to define jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug prevents non-Latin-1 characters from being used when defining tab controls. Using Template:Toolkit's "uri" filter converts the data to usable characters. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure -> tag 952 -> Edit subfields. - Under the "New" tab, add a subfield code which is outside the basic Latin character set, e.g. £, §, æ. - Save changes. - Edit any subfield code to load the subfield constraints page again. - Test that the subfield code tabs work correctly: Clicking each tab should load only the corresponding panel. - Test a variety of tabs including the one you created with the non-Latin character.
Wow that was fast! :) One thing to note is that not any character outside the basic Latin character should be accepted, as mentioned in Bug 9874 about ampersand.
(In reply to Pablo AB from comment #2) > One thing to note is that not any character outside the basic Latin > character should be accepted, as mentioned in Bug 9874 about ampersand. If you have more information about how the form should be validated you could file another bug. If my patch is working for you please sign off!
Created attachment 109684 [details] [review] Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints This patch changes the encoding of the data being used to define jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug prevents non-Latin-1 characters from being used when defining tab controls. Using Template:Toolkit's "uri" filter converts the data to usable characters. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure -> tag 952 -> Edit subfields. - Under the "New" tab, add a subfield code which is outside the basic Latin character set, e.g. £, §, æ. - Save changes. - Edit any subfield code to load the subfield constraints page again. - Test that the subfield code tabs work correctly: Clicking each tab should load only the corresponding panel. - Test a variety of tabs including the one you created with the non-Latin character. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 109935 [details] [review] Bug 26330: Change encoding of text used as tab triggers in MARC subfield constraints This patch changes the encoding of the data being used to define jQueryUI tabs on the MARC subfield constraints page. A jQueryUI bug prevents non-Latin-1 characters from being used when defining tab controls. Using Template:Toolkit's "uri" filter converts the data to usable characters. To test, apply the patch and go to Administration -> MARC frameworks -> MARC structure -> tag 952 -> Edit subfields. - Under the "New" tab, add a subfield code which is outside the basic Latin character set, e.g. £, §, æ. - Save changes. - Edit any subfield code to load the subfield constraints page again. - Test that the subfield code tabs work correctly: Clicking each tab should load only the corresponding panel. - Test a variety of tabs including the one you created with the non-Latin character. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x
I went ahead and backported this to 20.05.x for 20.05.08
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.