Strings defined for translation in members-menu.inc can now be wrapped in the new translation function and put in members-menu.js.
Created attachment 109424 [details] [review] Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js This patch moves translatable strings out of members-menu.inc into members-menu.js where they can be translated using the double-underscore i18n function. To test, apply the patch and go to Patrons. - Expand the search options in the search header by clicking the [+] link. - Select "Date of birth" from the "Search fields" dropdown. - A tooltip should appear above the search form, "Dates of birth should be entered in the format..." with your current date format. - Remove all "Adult" type patron categories but one. - Check out to a child patron. - From the "More" menu choose "Update child to adult patron." - You should see a confirmation. - From the checkout screen, from the "More" menu, choose "Renew patron" - You should get a confirmation.
Created attachment 109436 [details] [review] Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js This patch moves translatable strings out of members-menu.inc into members-menu.js where they can be translated using the double-underscore i18n function. To test, apply the patch and go to Patrons. - Expand the search options in the search header by clicking the [+] link. - Select "Date of birth" from the "Search fields" dropdown. - A tooltip should appear above the search form, "Dates of birth should be entered in the format..." with your current date format. - Remove all "Adult" type patron categories but one. - Check out to a child patron. - From the "More" menu choose "Update child to adult patron." - You should see a confirmation. - From the checkout screen, from the "More" menu, choose "Renew patron" - You should get a confirmation. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/members-menu.js for translation, e.g.: msgid "Are you sure you want to renew this patron's registration?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear.
Created attachment 110813 [details] [review] Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js This patch moves translatable strings out of members-menu.inc into members-menu.js where they can be translated using the double-underscore i18n function. To test, apply the patch and go to Patrons. - Expand the search options in the search header by clicking the [+] link. - Select "Date of birth" from the "Search fields" dropdown. - A tooltip should appear above the search form, "Dates of birth should be entered in the format..." with your current date format. - Remove all "Adult" type patron categories but one. - Check out to a child patron. - From the "More" menu choose "Update child to adult patron." - You should see a confirmation. - From the checkout screen, from the "More" menu, choose "Renew patron" - You should get a confirmation. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/members-menu.js for translation, e.g.: msgid "Are you sure you want to renew this patron's registration?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 110826 [details] [review] Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js This patch moves translatable strings out of members-menu.inc into members-menu.js where they can be translated using the double-underscore i18n function. To test, apply the patch and go to Patrons. - Expand the search options in the search header by clicking the [+] link. - Select "Date of birth" from the "Search fields" dropdown. - A tooltip should appear above the search form, "Dates of birth should be entered in the format..." with your current date format. - Remove all "Adult" type patron categories but one. - Check out to a child patron. - From the "More" menu choose "Update child to adult patron." - You should see a confirmation. - From the checkout screen, from the "More" menu, choose "Renew patron" - You should get a confirmation. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/members-menu.js for translation, e.g.: msgid "Are you sure you want to renew this patron's registration?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.05
enhancement, not backported to 19.11.x