Bug 26368 - Add support for OCLC Encoding level values
Summary: Add support for OCLC Encoding level values
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Katrin Fischer
URL:
Keywords: release-notes-needed
Depends on:
Blocks:
 
Reported: 2020-09-03 12:45 UTC by Nick Clemens
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/665
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 26368: Add OCLC options to marc21_leader.tt (2.33 KB, patch)
2020-09-03 12:53 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 26368: Add OCLC options to marc21_leader.tt (7.03 KB, patch)
2021-04-27 11:07 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 26368: Add OCLC options to marc21_leader.tt (7.08 KB, patch)
2022-09-21 18:22 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 26368: Add OCLC options to marc21_leader.tt (7.12 KB, patch)
2022-09-21 22:38 UTC, David Nind
Details | Diff | Splinter Review
Bug 26368: Add OCLC options to marc21_leader.tt (7.18 KB, patch)
2022-10-01 22:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 26368: Rephase system preference to sentence style (1.53 KB, patch)
2022-10-01 22:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 26368: (QA follow-up) Standardize spaces in option descriptions (1.79 KB, patch)
2022-10-01 22:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Nick Clemens 2020-09-03 12:53:28 UTC
Created attachment 109622 [details] [review]
Bug 26368: Add OCLC options to marc21_leader.tt

See documentation at:
https://www.oclc.org/bibformats/en/fixedfield/elvl.html

To test:
1 - Apply patch
2 - Edit a record
3 - Edit the leader
4 - Note the new options
5 - Set the value of encodign level to the new options and save
6 - Edit again
7 - Confirm the value is displayed correctly selected
Comment 2 Katrin Fischer 2020-09-03 18:28:50 UTC
If these are no MARC standard and OCLC is only used by a quite small percentage of libraries using Koha - could we make displaying these optional? Maybe we could introduce a second plugin that can be linked in frameworks or a general "OCLC participant" pref to switch on such things
Comment 3 Katrin Fischer 2020-09-03 18:30:04 UTC
Especially since the options are currently not marked as OCLC specific - I think they should be.
Comment 4 Nick Clemens 2021-04-27 11:07:22 UTC
Created attachment 120209 [details] [review]
Bug 26368: Add OCLC options to marc21_leader.tt

See documentation at:
https://www.oclc.org/bibformats/en/fixedfield/elvl.html

To test:
 1 - Apply patch, updatedatabase
 2 - Edit a record in the basic editor
 3 - Edit the leader using the plugin
 4 - Note the options for '17 - Encoding level'
 5 - Find the system preference 'UseOCLCEncodingLevels'
 6 - Edit the record again
 7 - Note new options I,J,K,M
 8 - Set the value of encodign level to one of the new options and save
 9 - Edit again
10 - Confirm the value is displayed correctly selected
11 - Repeat tests using advanced cataloging editor
Comment 5 David Nind 2022-06-01 06:03:36 UTC
Patch no longer applies 8-(..

git bz apply 26368

Bug 26368 - Add support for OCLC Encoding level values

120209 - Bug 26368: Add OCLC options to marc21_leader.tt

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 26368: Add OCLC options to marc21_leader.tt
Using index info to reconstruct a base tree...
M	installer/data/mysql/mandatory/sysprefs.sql
M	koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
M	koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
Auto-merging installer/data/mysql/mandatory/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql
error: Failed to merge in the changes.
Patch failed at 0001 Bug 26368: Add OCLC options to marc21_leader.tt
Comment 6 Nick Clemens 2022-09-21 18:22:07 UTC
Created attachment 140826 [details] [review]
Bug 26368: Add OCLC options to marc21_leader.tt

See documentation at:
https://www.oclc.org/bibformats/en/fixedfield/elvl.html

To test:
 1 - Apply patch, updatedatabase
 2 - Edit a record in the basic editor
 3 - Edit the leader using the plugin
 4 - Note the options for '17 - Encoding level'
 5 - Find the system preference 'UseOCLCEncodingLevels'
 6 - Edit the record again
 7 - Note new options I,J,K,M
 8 - Set the value of encodign level to one of the new options and save
 9 - Edit again
10 - Confirm the value is displayed correctly selected
11 - Repeat tests using advanced cataloging editor
Comment 7 David Nind 2022-09-21 22:38:07 UTC
Created attachment 140837 [details] [review]
Bug 26368: Add OCLC options to marc21_leader.tt

See documentation at:
https://www.oclc.org/bibformats/en/fixedfield/elvl.html

To test:
 1 - Apply patch, updatedatabase
 2 - Edit a record in the basic editor
 3 - Edit the leader using the plugin
 4 - Note the options for '17 - Encoding level'
 5 - Find the system preference 'UseOCLCEncodingLevels'
 6 - Edit the record again
 7 - Note new options I,J,K,M
 8 - Set the value of encodign level to one of the new options and save
 9 - Edit again
10 - Confirm the value is displayed correctly selected
11 - Repeat tests using advanced cataloging editor

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Katrin Fischer 2022-10-01 22:19:41 UTC
Created attachment 141197 [details] [review]
Bug 26368: Add OCLC options to marc21_leader.tt

See documentation at:
https://www.oclc.org/bibformats/en/fixedfield/elvl.html

To test:
 1 - Apply patch, updatedatabase
 2 - Edit a record in the basic editor
 3 - Edit the leader using the plugin
 4 - Note the options for '17 - Encoding level'
 5 - Find the system preference 'UseOCLCEncodingLevels'
 6 - Edit the record again
 7 - Note new options I,J,K,M
 8 - Set the value of encodign level to one of the new options and save
 9 - Edit again
10 - Confirm the value is displayed correctly selected
11 - Repeat tests using advanced cataloging editor

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2022-10-01 22:19:45 UTC
Created attachment 141198 [details] [review]
Bug 26368: Rephase system preference to sentence style

The preference was using a yes/no instead of the more common
display/don't display. This patch switches it to the latter
and adds a note about position 17.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2022-10-01 22:19:50 UTC
Created attachment 141199 [details] [review]
Bug 26368: (QA follow-up) Standardize spaces in option descriptions

Most options are labelles as x- description, but a few had
additional spaces. This just makes sure they all look the same.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Tomás Cohen Arazi 2022-10-03 11:32:35 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 12 Lucas Gass 2022-11-01 22:33:25 UTC
Enhancement will not be backported to 22.05.x series