26374 – Update for 19974 is not idempotent

Bug 26374 - Update for 19974 is not idempotent

Summary: Update for 19974 is not idempotent

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low major
Assignee:	Nick Clemens (kidclamp)
QA Contact:	Martin Renvoize (ashimema)

URL:
Keywords:

Depends on:	19974
Blocks:
	Show dependency tree / graph

Reported:	2020-09-03 16:35 UTC by Nick Clemens (kidclamp)
Modified:	2022-06-06 20:31 UTC (History)
CC List:	6 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	21.11.00,21.05.05,20.11.12,20.05.18
Circulation function:

Attachments
Bug 26374: update from bug 19974 is not idempotent (915 bytes, patch) 2020-09-03 16:36 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Bug 26388: Do not show 'Renew all' or 'Renew selected' if no renewable items (4.42 KB, patch) 2020-09-04 14:30 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Bug 26374: update from bug 19974 is not idempotent (916 bytes, patch) 2020-09-04 18:05 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Bug 26374: update from bug 19974 is not idempotent (981 bytes, patch) 2021-10-28 08:12 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nick Clemens (kidclamp) 2020-09-03 16:35:37 UTC

Comment 1 Nick Clemens (kidclamp) 2020-09-03 16:36:42 UTC

Created attachment 109633 [details] [review]
Bug 26374: update from bug 19974 is not idempotent

Comment 2 Nick Clemens (kidclamp) 2020-09-04 14:30:30 UTC Comment hidden (obsolete)

Created attachment 109664 [details] [review]
Bug 26388: Do not show 'Renew all' or 'Renew selected' if no renewable items

Additionally, only include renewable items in 'Renew all'

To test:
1 - Check out some items to a patron, ideally:
    Some not renewable because set for auto renewal
    Some not renewable because of holds
    Some renewable
 2 - Confirm 'Renew selected' and 'Renew all' show on the opac
 3 - Click 'Renew all'
 4 - You get errors about the non-renewable items?
 5 - Check in all renewable items
 6 - Confirm you still see renew buttons
 7 - Apply patch
 8 - Refresh and you shoudl not see renew buttons
 9 - Check out a renewable item
10 - Click 'Renew all'
11 - Renewable item is renewed with no error
12 - Try again with 'Renew selected'
13 - Confirm it works as expected

Comment 3 Nick Clemens (kidclamp) 2020-09-04 18:05:50 UTC

Created attachment 109681 [details] [review]
Bug 26374: update from bug 19974 is not idempotent

Comment 4 Aleisha Amohia 2021-01-19 22:30:42 UTC

Does this depend on Bug 19974? Can you please provide a test plan?

Comment 5 Nick Clemens (kidclamp) 2021-04-21 18:27:15 UTC

(In reply to Aleisha Amohia from comment #4)
> Does this depend on Bug 19974? Can you please provide a test plan?

It does depend on 19974

Essentially run the update statement, set some values, run it again, they are deleted.

I believe this was noticed because of internal backports, filing here because it could happen to others

Comment 6 Martin Renvoize (ashimema) 2021-10-28 08:12:57 UTC

Created attachment 127027 [details] [review]
Bug 26374: update from bug 19974 is not idempotent

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 7 Martin Renvoize (ashimema) 2021-10-28 08:13:23 UTC

Clear and understandable fix.. tested.

Going straight for QA

Comment 8 Jonathan Druart 2021-10-28 10:29:42 UTC

Pushed to master for 21.11, thanks to everybody involved!

Comment 9 Kyle M Hall (khall) 2021-10-29 15:46:49 UTC

Pushed to 21.05.x for 21.05.05

Comment 10 Fridolin Somers 2021-11-10 23:45:35 UTC

Pushed to 20.11.x for 20.11.12

Comment 11 Victor Grousset/tuxayo 2021-11-15 04:41:47 UTC

Backported: Pushed to 20.05.x branch for 20.05.18

Comment 12 Wainui Witika-Park 2021-11-23 00:11:32 UTC

Not backporting to 19.11.x - LTS version will just backport security patches