We need to catch missing execution flags for some scripts, like the ones in svc and misc It could be good to have a qa-test-tools check as well.
I was thinking this as well. There are some maintenance scripts that probably don't *need* the execute permission, but it wouldn't hurt to add it to them.
*** Bug 26382 has been marked as a duplicate of this bug. ***
Created attachment 109691 [details] [review] Bug 26384: Add test to catch for missing or extra execution flags
Created attachment 109692 [details] [review] Bug 26384: Fix executable flags .pm must not have -x .t must have -x .pl must have -x Test plan: Apply only the first patch, run the tests and confirm that the failures make sense Apply this patch and confirm that the test now returns green
Created attachment 109845 [details] [review] Bug 26384: Add test to catch for missing or extra execution flags Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good call, test works perfectly.. Final patch no longer applies as one of the touched files is no longer present.
Created attachment 109847 [details] [review] Bug 26384: Fix executable flags .pm must not have -x .t must have -x .pl must have -x Test plan: Apply only the first patch, run the tests and confirm that the failures make sense Apply this patch and confirm that the test now returns green
Created attachment 109848 [details] [review] Bug 26384: Add test to catch for missing or extra execution flags Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 109884 [details] [review] Bug 26384: Fix executable flags .pm must not have -x .t must have -x .pl must have -x Test plan: Apply only the first patch, run the tests and confirm that the failures make sense Apply this patch and confirm that the test now returns green Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 109885 [details] [review] Bug 26384: Add test to catch for missing or extra execution flags Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 109886 [details] [review] Bug 26384: (QA follow-up) Fix two exceptions AuthUtils.t went back to 644, but should be 755 Adding an exception in the xt test for fix-old-fsf-address.exclude Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 20.11, thanks to everybody involved!
Created attachment 110834 [details] [review] Bug 26384: Add .t extension to make the script executed by CI The test file is not run as it does not have the .t extension
I have added a test in the QA script. https://gitlab.com/koha-community/qa-test-tools/-/issues/39
does not apply cleanly to 20.05.x, no backport