The "Credit type" pull down on the "Manual credit" page contains untranslatable values. To test: - Make sure another language than English is installed (tested with de-DE) - Go to any patron account - Accounting tab - Create manual credit tab - Verify the credit type pull down is there - Switch language to non-English - Verify the values remain in English
This also applies to the debit type dropdown in Manual invoice. I think I was waiting on bug 24975 to base work on to make this more flexible with regards translations. I think it could be done, but wouldn't be trivial, using the existing template level include translations (the challenge is that the dropdown is built from a list of credit_types/debit_types whereas the existing template include is designed to receive accountline rows).
It is a regression to previous versions. We should at least catch the default Forgiven and Credit on template level for translations.
Created attachment 109701 [details] [review] Bug 26398: Restore translations for credit/debit type dropdown
Patch no longer applies 8-(..
Created attachment 111219 [details] [review] Bug 26398: Restore translations for credit/debit type dropdown
The values are still in English after applying for me, I'm sure I'm missing something for testing this one...
This one is a bit challenging for me to write a test plan as I only just understand the translation workflow myself. What the patch does is update the templates to include the English strings for translation in the right places. Regression tests * Create some debts and payments of various types. * Check that they appear as expected in the accounts tables on both the transactions and pay tabs of the members page. Bug fix test * We need to check that the strings appear in .po files. I believe this is a case of running the 'update' method of misc/translator/translator script. * The final aim of the bug is to make the drop-down options for manual invoice and manual credit type drop downs are translated. Katrin, perhaps you could lend a hand on how this can be properly tested?
Ok, here's what I did to test 1) run ./translate update xx-XX 2) Translate this big chunk in your xx-XX-staff-prog.po or make sure it's translated #: intranet-tmpl/prog/en/includes/accounts.inc:2 #, c-format msgid "" "%s %s %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund " "%sRefund %s%s %s %s %s %sAccount creation fee %sAccount renewal fee %sLost " "item %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee " "%sDaily rental fee %sRenewal of rental item %sRenewal of daily rental item " "%sHold fee %sHold waiting too long %sPayout %s%s %s %s %s " (tip: I search the po file for "Forgiven", there are only two occurrences) 3) run ./translate install xx-XX 4) In your staff interface in your other language, go to a patron's account > Accounting > Create manual Credit 5) Check that the values in the credit drop down are in English 6) Apply patch 7) redo steps 1-4 (careful, the string to be translated changes) 8) Do a hard refresh (Ctrl+F5) (I guess you'd have to restart plack if you have it) 9) Values in the credit drop down are translated
Created attachment 111928 [details] [review] Bug 26398: Restore translations for credit/debit type dropdown Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
That's a great test plan Caroline, thanks, I shall grab it for other similar bugs.. thanks so much for t sting and moving this on. [U+1F600]
Created attachment 111941 [details] [review] Bug 26398: Restore translations for credit/debit type dropdown 1) run ./translate update xx-XX 2) Translate this big chunk in your xx-XX-staff-prog.po or make sure it's translated msgid "" "%s %s %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund " "%sRefund %s%s %s %s %s %sAccount creation fee %sAccount renewal fee %sLost " "item %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee " "%sDaily rental fee %sRenewal of rental item %sRenewal of daily rental item " "%sHold fee %sHold waiting too long %sPayout %s%s %s %s %s " (tip: I search the po file for "Forgiven", there are only two occurrences) 3) run ./translate install xx-XX 4) In your staff interface in your other language, go to a patron's account > Accounting > Create manual Credit 5) Check that the values in the credit drop down are in English 6) Apply patch 7) redo steps 1-4 (careful, the string to be translated changes) 8) Do a hard refresh (Ctrl+F5) (I guess you'd have to restart plack if you have it) 9) Values in the credit drop down are translated Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc Please rebase.
Created attachment 112844 [details] [review] Bug 26398: Restore translations for credit/debit type dropdown 1) run ./translate update xx-XX 2) Translate this big chunk in your xx-XX-staff-prog.po or make sure it's translated msgid "" "%s %s %sPayment %sWriteoff %sForgiven %sCredit %sLost item fee refund " "%sRefund %s%s %s %s %s %sAccount creation fee %sAccount renewal fee %sLost " "item %sManual fee %sNew card %sFine %sLost item processing fee %sRental fee " "%sDaily rental fee %sRenewal of rental item %sRenewal of daily rental item " "%sHold fee %sHold waiting too long %sPayout %s%s %s %s %s " (tip: I search the po file for "Forgiven", there are only two occurrences) 3) run ./translate install xx-XX 4) In your staff interface in your other language, go to a patron's account > Accounting > Create manual Credit 5) Check that the values in the credit drop down are in English 6) Apply patch 7) redo steps 1-4 (careful, the string to be translated changes) 8) Do a hard refresh (Ctrl+F5) (I guess you'd have to restart plack if you have it) 9) Values in the credit drop down are translated Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
does not apply clean 20.05.x, no backport