The description of REFUND type accountline credits introduced with the "issue refund" feature is not translatable. To test: - Make sure a language with a complete translation is installed - Switch to the language - Go to any user account - Add a manual invoice - Pay it off fully or partially - Click on "issue refund" - Confirm the refund - Check the description of the line in the patron account is not translated.
Created attachment 109820 [details] [review] Bug 26418: Fix translatability of REFUND credit type
Created attachment 110559 [details] [review] Bug 26418: Fix translatability of REFUND credit type Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 110625 [details] [review] Bug 26418: Fix translatability of REFUND credit type The description of REFUND type accountline credits introduced with the "issue refund" feature is not translatable. To test: - Make sure a language with a complete translation is installed - Switch to the language - Go to any user account - Add a manual invoice - Pay it off fully or partially - Click on "issue refund" - Confirm the refund - Check the description of the line in the patron account is not translated. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 110626 [details] [review] Bug 26418: Fix translatability of REFUND credit type The description of REFUND type accountline credits introduced with the "issue refund" feature is not translatable. To test: - Make sure a language with a complete translation is installed - Switch to the language - Go to any user account - Add a manual invoice - Pay it off fully or partially - Click on "issue refund" - Confirm the refund - Check the description of the line in the patron account is not translated. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
doesn't apply clean to 20.05.x, no backport
Could we maybe get a rebase here? This is an issue visible in the OPAC and would love to see it fixed.
Created attachment 112195 [details] [review] Bug 26418: [20.05] Fix translatability of REFUND credit type The description of REFUND type accountline credits introduced with the "issue refund" feature is not translatable. To test: - Make sure a language with a complete translation is installed - Switch to the language - Go to any user account - Add a manual invoice - Pay it off fully or partially - Click on "issue refund" - Confirm the refund - Check the description of the line in the patron account is not translated. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
20.05 rebased patch attached.