Since Bug 17762, it is possible to translate notices. But script misc/cronjobs/overdue_notices.pl does not test if preference system is active and does not call C4::Letters::getletter with $lang parameter So if preference system is active and default template not filled because you want translated notices, their is no notice generated at all.
Created attachment 109837 [details] [review] Bug 26420: Use translated notices for overdue_notices.pl This script does not pass the patron's preferred lang for notices. Test plan: Enable TranslateNotices Create a patron with a preferred lang for notices != default Translate ODUE for this language Setup the overdue notices for this patron's category Check an item out for this patron (select the correct due date to trigger the notice) Run the script overdue_notices.pl Check the message_queue table and confirm that the notice enqueued is translated
Created attachment 110036 [details] [review] Bug 26420: Use translated notices for overdue_notices.pl This script does not pass the patron's preferred lang for notices. Test plan: Enable TranslateNotices Create a patron with a preferred lang for notices != default Translate ODUE for this language Setup the overdue notices for this patron's category Check an item out for this patron (select the correct due date to trigger the notice) Run the script overdue_notices.pl Check the message_queue table and confirm that the notice enqueued is translated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, Signing off
Created attachment 110123 [details] [review] Bug 26420: Use translated notices for overdue_notices.pl This script does not pass the patron's preferred lang for notices. Test plan: Enable TranslateNotices Create a patron with a preferred lang for notices != default Translate ODUE for this language Setup the overdue notices for this patron's category Check an item out for this patron (select the correct due date to trigger the notice) Run the script overdue_notices.pl Check the message_queue table and confirm that the notice enqueued is translated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.05
backported to 19.11.x for 19.11.11
Backported to 19.05.x branch for 19.05.16
Shouldn't we still fall back to the default language if a tranlation is missing? I reported bug 28487.
(In reply to Andreas Jonsson from comment #9) > Shouldn't we still fall back to the default language if a tranlation is > missing? I reported bug 28487. I think you are correct.