The OPAC blocks login of the account specified in the AutoSelfCheckID syspref (even if the AutoSelfCheckAllowed syspref is off and the account in question doesn't have self_check permissions). The descriptive text on the syspref should warn of this.
Created attachment 109964 [details] [review] Bug 26435: Add warning to AutoSelfCheck sysprefs To test: 1- apply patch, restart 2- look up AutoSelfCheck sysprefs 3- confirm new note in description
Created attachment 109965 [details] [review] Bug 26435: Add warning to AutoSelfCheck sysprefs To test: 1- apply patch, restart 2- look up AutoSelfCheck sysprefs 3- confirm new note in description Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 109985 [details] [review] Bug 26435: Add warning to AutoSelfCheck sysprefs To test: 1- apply patch, restart 2- look up AutoSelfCheck sysprefs 3- confirm new note in description Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 109986 [details] [review] Bug 26435: (QA follow-up) Fix terminology: borrower to patron in new hint Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 109987 [details] [review] Bug 26435: (QA follow-up) Terminology: Fix some more borrowers in other preferences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thanks, Katrin! I just moved my bookmark for https://wiki.koha-community.org/wiki/Terminology to somewhere I'll (hopefully) remember to check it!
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.05
enhancement, not backported to 19.11.x