I propose to reformat the MARC subfield structure template (marc_subfields_structure.tt) so that it has consistent spacing and indentation.
Created attachment 110065 [details] [review] Bug 26456: Reindent MARC subfield structure template This patch reindents the MARC subfield structure template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields.. Test adding, editing, and deleting subfields. Confirm that changes are saved correctly.
Created attachment 110066 [details] [review] Bug 26456: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. Also changed: Some form hints have been wrapped in <div class="hint"> to make it consistent with other pages. This patch should have no effect on functionality.
Patch no longer applies 8-(
Created attachment 111306 [details] [review] Bug 26456: Reindent MARC subfield structure template This patch reindents the MARC subfield structure template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields.. Test adding, editing, and deleting subfields. Confirm that changes are saved correctly.
Created attachment 111307 [details] [review] Bug 26456: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. Also changed: Some form hints have been wrapped in <div class="hint"> to make it consistent with other pages. This patch should have no effect on functionality.
Created attachment 111363 [details] [review] Bug 26456: Reindent MARC subfield structure template This patch reindents the MARC subfield structure template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields.. Test adding, editing, and deleting subfields. Confirm that changes are saved correctly. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 111364 [details] [review] Bug 26456: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. Also changed: Some form hints have been wrapped in <div class="hint"> to make it consistent with other pages. This patch should have no effect on functionality. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 111560 [details] [review] Bug 26456: Reindent MARC subfield structure template This patch reindents the MARC subfield structure template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields.. Test adding, editing, and deleting subfields. Confirm that changes are saved correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 111561 [details] [review] Bug 26456: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. Also changed: Some form hints have been wrapped in <div class="hint"> to make it consistent with other pages. This patch should have no effect on functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x