Bug 23777 switched request.tt to use Branches plugin, but inadvertently replace the comma in the JSON with a semicolon
Created attachment 110072 [details] [review] Bug 26460: Fix line ending in JSON Wrong line ending in JSON causes error: Uncaught SyntaxError: missing } after property list note: { opened at line 29579, column 15 To test: 1 - Have a title with some items not for hold in staff interface 2 - Set AllowHoldPolicyOverride to 'Allow' 3 - Attempt to place hold on the title 4 - Note JS error in the console and datatable does not load for items 5 - Apply patch 6 - Reload 7 - Error is cleared, table loads correctly
Created attachment 110183 [details] [review] Bug 26460: Fix line ending in JSON Wrong line ending in JSON causes error: Uncaught SyntaxError: missing } after property list note: { opened at line 29579, column 15 To test: 1 - Have a title with some items not for hold in staff interface 2 - Set AllowHoldPolicyOverride to 'Allow' 3 - Attempt to place hold on the title 4 - Note JS error in the console and datatable does not load for items 5 - Apply patch 6 - Reload 7 - Error is cleared, table loads correctly Signed-off-by: David Nind <david@davidnind.com>
Created attachment 110231 [details] [review] Bug 26460: Fix line ending in JSON Wrong line ending in JSON causes error: Uncaught SyntaxError: missing } after property list note: { opened at line 29579, column 15 To test: 1 - Have a title with some items not for hold in staff interface 2 - Set AllowHoldPolicyOverride to 'Allow' 3 - Attempt to place hold on the title 4 - Note JS error in the console and datatable does not load for items 5 - Apply patch 6 - Reload 7 - Error is cleared, table loads correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.05
*** Bug 26733 has been marked as a duplicate of this bug. ***
missing dependencies, not backported to 19.11.x