Hello! I was trying to find out how to hide the "Home library" column from the transactions table in the patron's account (Patron account > Accounting tab > Transactions tab). The right column id in Table settings is account-fines (Administration > Table settings > Patrons > account-fines). There are two problems here: 1) The home library column doesn't appear in the table settings for account-fines 2) Checking the notes column in the account-fines table settings hides the home library column This means that because there are columns missing, the other ones are off. To replicate on master: 1) Go to a patron's account 2) Click on the Accounting tab and then the Transactions tab 3) In another browser tab, go to Administration > Table settings > Patrons 4) In the account-fines table, check the box to hide the Notes column 5) Go back to the patron's account and refresh the page. Notice the Notes column is still there but the Home library column is not there anymore I think Home library is the only missing column.
Created attachment 110440 [details] [review] Bug 24690: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option
Created attachment 110546 [details] [review] Bug 24690: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option https://bugs.koha-community.org/show_bug.cgi?id=26490 Signed-off-by: David Nind <david@davidnind.com>
Created attachment 110742 [details] [review] Bug 26490: Fix column configuration for fines trasactions Hiding the last columns on the fines transactions in the patron account in staff didn't work correctly as we had missed adding Home library to the configuration options when it was added. This adds the missing definition and now all columns can be toggled correctly. To test: - Go to any patron account in staff - Go to Accounting > tab transactions (maybe add some fines) - Toggle the columns on the table using the menu, especially - notes, home library and checkout date - Go to Administration > Table configuration - Verify the settings for the table work well from there too - with the patch, home_library will show as new option Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Ooops; Works as expected, thanks for the fix Katrin. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
doesnt apply cleanly to 20.05.x, no backport