In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used.
Created attachment 110765 [details] Screenshot
Created attachment 110766 [details] [review] Bug 26538: Display cities list before input text In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. Test plan : 1) Create some cities 2) Open patron creation form 3) Check you see for each city field : cities list, text "or enter", text input 4) Delete all cities 5) Open patron creation form 6) Check you see for each city field : only text input
I like this change -- staff at my library seem to often forget they can select a predefined city. Unfortunately parts of it aren't working for me: Selecting "main address" cit or "alternate address" city does not trigger the automatic population of values to the city, state, and zip fields. It does work for the "alternate contact" fields.
(In reply to Owen Leonard from comment #3) > I like this change -- staff at my library seem to often forget they can > select a predefined city. > > Unfortunately parts of it aren't working for me: Selecting "main address" > cit or "alternate address" city does not trigger the automatic population of > values to the city, state, and zip fields. > > It does work for the "alternate contact" fields. Ah, for me this does no work on master without my patch ^^
Oh I found why, I'm on a patch
(In reply to Fridolin SOMERS from comment #5) > Oh I found why, I'm on a patch Bug 26556 is now in master (whaoo fast). You can test again
Patch no longer applies 8-(
Created attachment 111518 [details] [review] Bug 26538: Display cities list before input text In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. Test plan : 1) Create some cities 2) Open patron creation form 3) Check you see for each city field : cities list, text "or enter", text input 4) Delete all cities 5) Open patron creation form 6) Check you see for each city field : only text input
Rebased, thanks a lot for testing David :D
Created attachment 111540 [details] [review] Bug 26538: Display cities list before input text In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. Test plan : 1) Create some cities 2) Open patron creation form 3) Check you see for each city field : cities list, text "or enter", text input 4) Delete all cities 5) Open patron creation form 6) Check you see for each city field : only text input Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 111565 [details] [review] Bug 26538: Display cities list before input text In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. Test plan : 1) Create some cities 2) Open patron creation form 3) Check you see for each city field : cities list, text "or enter", text input 4) Delete all cities 5) Open patron creation form 6) Check you see for each city field : only text input Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.06
enhancement, not backported to 19.11.x