In 20.05 there is a button that will allow libraries to apply a discount to a fine/charge. The image of the button shows a % percentage sign, however, this is not how the discount is applied in Koha, it is applied as a $ dollar amount. Can we have either the icon of the % removed or replaced - as to not confuse users? Thanks
I had the same misunderstanding about the button the first time, I think a change would make sense. Please just avoid $ and similar for symbols as these don't apply to all countries.
Oh yes Katrin - good point. So just removing of the % and keeping the Description works!
Created attachment 110774 [details] [review] Bug 26541: Remove percent sign from discount button To test: 1 - go to borrower account, apply manual fee 2 - go to Transactions tab and see that fee has "% Apply discount" button 3 - apply patch, restart, reload page 4 - button just says "Apply discount"
I went with no icon as I really couldn't think of what might be helpful, but am certainly open to something else. There's a really nice Live Long and Prosper: https://fontawesome.com/v4.7.0/icons/
Created attachment 110775 [details] [review] Bug 26541: Remove percent sign from discount button Realized I'd left a stray tag, fixed. To test: 1 - go to borrower account, apply manual fee 2 - go to Transactions tab and see that fee has "% Apply discount" button 3 - apply patch, restart, reload page 4 - button just says "Apply discount"
Created attachment 110778 [details] [review] Bug 26541: Remove percent sign from discount button Realized I'd left a stray tag, fixed. To test: 1 - go to borrower account, apply manual fee 2 - go to Transactions tab and see that fee has "% Apply discount" button 3 - apply patch, restart, reload page 4 - button just says "Apply discount" Signed-off-by: David Nind <david@davidnind.com>
Created attachment 110782 [details] [review] Bug 26541: Remove percent sign from discount button Realized I'd left a stray tag, fixed. To test: 1 - go to borrower account, apply manual fee 2 - go to Transactions tab and see that fee has "% Apply discount" button 3 - apply patch, restart, reload page 4 - button just says "Apply discount" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.05
missing dependencies, not backported to 19.11.x