See bug 18432 and bug 22716 We missed the db explanantions for system preferences: MariaDB [koha_kohadev]> select variable,explanation from systempreferences where explanation like '% his %'; +-------------------------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------+ | variable | explanation | +-------------------------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------+ | AcqViewBaskets | Define which baskets a user is allowed to view: his own only, any within his branch or all | | AllowPatronToSetCheckoutsVisibilityForGuarantor | If enabled, the patron can set checkouts to be visible to his or her guarantor | | AllowPatronToSetFinesVisibilityForGuarantor | If enabled, the patron can set fines to be visible to his or her guarantor | | HighlightOwnItemsOnOPAC | If on, and a patron is logged into the OPAC, items from his or her home library will be emphasized and shown first in search results and item details. | | LoadSearchHistoryToTheFirstLoggedUser | If ON, the next user will automatically get the last searches in his history | | PatronSelfRegistrationVerifyByEmail | If enabled, any patron attempting to register themselves via the OPAC will be required to verify themselves via email to activate his or her account. | +-------------------------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------+
This is going to be super fun for French translators where french doesn't have gender-neutral pronouns! Quite in favor of this improvement (and language evolution) though :)
Created attachment 110989 [details] [review] Bug 26569: Use gender neutral pronouns in system prefernece explanations To test: 1 - perform query "select variable,explanation from systempreferences where explanation like '% his %';" 2 - find 6 sysprefs with gendered pronouns used in explanations 3 - apply patch, reset_all 4 - repeat query 5 - no more gendered pronouns!
Created attachment 111280 [details] [review] Bug 26569: Use gender neutral pronouns in system prefernece explanations To test: 1 - perform query "select variable,explanation from systempreferences where explanation like '% his %';" 2 - find 6 sysprefs with gendered pronouns used in explanations 3 - apply patch, reset_all 4 - repeat query 5 - no more gendered pronouns! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Well.. this is a fun one. I think we should just drop all the explanations in the DB myself.. they're not used anywhere in the UI (The .pref files are instead). The only place where these can surface are for locally added preferences where people have customised their Koha's. We can leave the field there for those.
(In reply to Martin Renvoize from comment #4) > Well.. this is a fun one. > > I think we should just drop all the explanations in the DB myself.. they're > not used anywhere in the UI (The .pref files are instead). > > The only place where these can surface are for locally added preferences > where people have customised their Koha's. We can leave the field there for > those. The DB update for such a drop will be a little interesting though.. either we need to read the .pref files and only null the field for those prefs not matching prefnames present in the .pref files.. or we do a one time list of all prefs that should be present and drop the explanation for that list.
Created attachment 111803 [details] [review] Bug 26569: Use gender neutral pronouns in system prefernece explanations To test: 1 - perform query "select variable,explanation from systempreferences where explanation like '% his %';" 2 - find 6 sysprefs with gendered pronouns used in explanations 3 - apply patch, reset_all 4 - repeat query 5 - no more gendered pronouns! Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Every little bit helps :)
Thanks Katrin! Martin, I don't disagree about just dropping unused text ultimately, it's just a bigger job for another bug.
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.06
backported to 19.11.x for 19.11.12
Backported to 19.05.x branch for 19.05.17