Bug 26585 - Cataloguing interface throws JS errors on load
Summary: Cataloguing interface throws JS errors on load
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Browser compatibility (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Alex Buckley
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-30 21:33 UTC by Alex Buckley
Modified: 2021-06-14 21:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buckley 2020-09-30 21:33:26 UTC
Bug 8643 introduced the 'mandatory' default parameter into addbiblio.tt

function AreFieldsNotOk (mandatory = true) {

This works fine in Chrome and Firefox, but Internet Explorer 11 does not allow default parameters and errors with: Expected ')'

See https://stackoverflow.com/questions/42768964/proper-way-to-define-default-values-for-function-arguments-in-javascript/42769077

We should not use default parameters which error in IE, and instead set a default value for mandatory inside the function body.
Comment 1 Katrin Fischer 2020-09-30 21:35:40 UTC
Hi Alex, not opposed to a fix, but we have recently decided to no longer officially support IE as even Microsoft seems to be pushing for Edge in older Windows versions (from what I understood from discussion, see bug 26305)
Comment 2 Alex Buckley 2020-09-30 21:55:48 UTC
Hi Katrin, thank you very much for noting that - I wasn't aware that decision had been made. It does make a lot of sense to stop supporting IE at this point, given Microsoft is.

I think I'll close this ticket off. Just because we believe if libraries do want to continue using Koha in IE then any fixes to do so should really be customisations rather than asking the community to maintain them. 

Thanks again
Alex
Comment 3 David Cook 2020-09-30 23:02:54 UTC
(In reply to Alex Buckley from comment #2)
> Hi Katrin, thank you very much for noting that - I wasn't aware that
> decision had been made. It does make a lot of sense to stop supporting IE at
> this point, given Microsoft is.
> 
> I think I'll close this ticket off. Just because we believe if libraries do
> want to continue using Koha in IE then any fixes to do so should really be
> customisations rather than asking the community to maintain them. 
> 
> Thanks again
> Alex

Sounds good! At some point, I'm going to finish off Bug 26305, which might help make the collective understanding of not supporting IE anymore more consistent.