misc/cronjobs/overdue_notices.pl -text option does not use utf8 to print/output the texts - this renders german umlauts unreadable
Created attachment 112006 [details] [review] 0001-Bug-26601-add-utf8-output-to-text-output-of-overdue_.patch also a test on howto submit koha patches
Hi Mark, this already looks good! Some small things: - the subject line should always start with Bug XXXX: description of fix - a description of the problem should be included - and a step by step test plan Finally, once a patch is uploaded, make sure to switch the status to "Needs Signoff" as this will be the queue/search testers are looking at.
Hi, thanks for the feedback - do you mean the subject line of the patch I guess - or some other? Subject: [PATCH] Bug [26601]: [add utf8 output to text output of overdue_notices.pl] Shall I change anything now or is it OK for this one - I'll try to improve next time
Created attachment 112112 [details] [review] Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 1/ Create ODUE text with a utf8 encoded characher, eg german umlauts <url>/cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ODUE 2/ Run perl overdue_notices.pl -text [-library <library-name>] -test 3/ Confirm text now inludes properly encoded umlauts Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This works great, thanks Mark. I've signed off and updated the commit message to adhere to current guidelines for you.. now Katrin to finish the process by QAing :) Great to have you aboard.
Created attachment 112124 [details] [review] Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 0/ Check out an item with due date yesterday (use specify due date) 1/ Create ODUE text with utf8 encoded characters, chinese characters, umlauts etc <url>/cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ODUE 2/ Run perl overdue_notices.pl -text ./ 3/ Verify encoding in the generated text file is incorrect 4/ Apply patch and repeat 2/ 3/ Confirm text now inludes properly encoded characters Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> With German umlauts on my system the editor still showed the characters correctly (probably guessing the right encoding). Using Chinese made the problem visible.
Fleshed out the test plan a little bit more and also tested the csv option that appears to work correctly.
Pushed to master for 20.11, thanks to everybody involved!
Congratulations Mark for your first patch pushed!
backported to 20.05.x for 20.05.06
backported to 19.11.x for 19.11.12
Backported to 19.05.x branch for 19.05.17