After bug 26394 that picked the local changes from the git stats website, we need to adjust it to reduce the number of invalid authors. We already did the job (partly) on the release-tools scripts (https://gitlab.com/koha-community/release-tools/-/blob/master/etc/dev_map.yaml).
Created attachment 111314 [details] [review] Bug 26621: Adjust .mailmap to reduce the number of invalid authors This file is a nightmare, really. We should simplify it and order it correctly. Letting it here for now, I'd like to run the gitstats command on it to double check the output.
(In reply to Jonathan Druart from comment #1) > This file is a nightmare, really. We should simplify it and order it > correctly. > Letting it here for now, I'd like to run the gitstats command on it to > double check the output. Sounds good to me
Created attachment 111326 [details] [review] Bug 26621: Adjust .mailmap to reduce the number of invalid authors This file is a nightmare, really. We should simplify it and order it correctly. Letting it here for now, I'd like to run the gitstats command on it to double check the output.
Created attachment 111327 [details] [review] Bug 26621: Adjust docs/contributors.yaml accordingly
With this last patch gitstats generates 427 authors with 2 who are not in the history.txt: "ByWater Solutions Team" and "BibLibre Team". We have, in history.txt 429th authors, but we are missing 3rd, 4th and 6th devs.
Created attachment 111332 [details] [review] Bug 26621: Adjust .mailmap to reduce the number of invalid authors This file is a nightmare, really. We should simplify it and order it correctly. Letting it here for now, I'd like to run the gitstats command on it to double check the output. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 111333 [details] [review] Bug 26621: Adjust docs/contributors.yaml accordingly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Checked and confirmed the changes make sense.. nice work! As for the early developers that were missing, when I discussed this with Chris a while back it was due to the way things were committed in the early days on SVN... I think they shared a commit bit and so things went in under one name/user and the history file reflects his personal knowledge of who joined the team when at that early stage before they split out commit bits. Signing off.
Created attachment 111662 [details] [review] Bug 26621: Adjust .mailmap to reduce the number of invalid authors This file is a nightmare, really. We should simplify it and order it correctly. Letting it here for now, I'd like to run the gitstats command on it to double check the output. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 111663 [details] [review] Bug 26621: Adjust docs/contributors.yaml accordingly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
The file might still be a bit messy, but this reads as a nice improvement overall. Small steps.
Created attachment 111690 [details] [review] Bug 26621: Adjust .mailmap to reduce the number of invalid authors This file is a nightmare, really. We should simplify it and order it correctly. Letting it here for now, I'd like to run the gitstats command on it to double check the output. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD: Amended patch: remove dup occurrences for Brendan
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x
Backported: Pushed to 20.05.x branch for 20.05.13
Not backported to 19.11.x Enhancement
Backported to 19.11.x for 19.11.19