The checkboxes on an OPAC list page do not have aria-labels. This means that users of screenreaders and other assistive technology are not informed of a checkbox's purpose. To reproduce issue: 1/ Open a list on the OPAC 2/ Inspect the checkbox for a list item and confirm that there isn't an aria-label As an extra optional step, use an accessibility checker - e.g. the WAVE Accessibility evaluation tool (https://wave.webaim.org/extension/) or Tota11y (https://khan.github.io/tota11y/) - to confirm that this is an accessibility issue. Current code example: <input type="checkbox" class="cb" name="biblionumber" value="114"> Solution example: <input type="checkbox" class="cb" name="biblionumber" value="114" aria-label="Select list item: Clean code :"> Bug 25244 fixed a similar issue for OPAC search results.
Created attachment 111441 [details] [review] Bug 26655: Add ARIA Labels to OPAC Lists This patch adds ARIA labels to opac-shelves.tt so that checkboxes for list items are meaningful to users of screenreaders and other assistive technology. Test Plan: 1/ Open an OPAC list 2/ Inspect the checkbox for a list item 3/ Confirm the aria-label is missing 4/ Apply the patch 5/ Refresh the Opac list page 6/ Inspect the checkbox for a list item 7/ Note that there is now an aria-label with a meaningful description 8/Sign off
Created attachment 111542 [details] [review] Bug 26655: Add ARIA Labels to OPAC Lists This patch adds ARIA labels to opac-shelves.tt so that checkboxes for list items are meaningful to users of screenreaders and other assistive technology. Test Plan: 1/ Open an OPAC list 2/ Inspect the checkbox for a list item 3/ Confirm the aria-label is missing 4/ Apply the patch 5/ Refresh the Opac list page 6/ Inspect the checkbox for a list item 7/ Note that there is now an aria-label with a meaningful description 8/Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 111562 [details] [review] Bug 26655: Add ARIA Labels to OPAC Lists This patch adds ARIA labels to opac-shelves.tt so that checkboxes for list items are meaningful to users of screenreaders and other assistive technology. Test Plan: 1/ Open an OPAC list 2/ Inspect the checkbox for a list item 3/ Confirm the aria-label is missing 4/ Apply the patch 5/ Refresh the Opac list page 6/ Inspect the checkbox for a list item 7/ Note that there is now an aria-label with a meaningful description 8/Sign off Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
does not apply clean to 20.05.x, no backport Henry, if you wan to rebase this I would gladly backport
Thanks Lucas, I will try and rebase.