The column 'Last seen' on the results page of inventory.pl doesn't sort correctly. Only the date is taken into account, not the whole date. That was already described in Bug 24601, but here on the page inventory.pl. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24601
I mean day, not date
Created attachment 111822 [details] [review] Bug 26664: Fix sorting for date last seen in inventory tool This adds the standard datatable sorting for dates to the inventory table as described here: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference To test: - Go to the inventory tool - Search for a big sample list of items with different date last seen - Sort the table now by "date last seen" by clicking on the table header cell - Try different settings of the DateFormat system preferences - Verify sorting is incorrect (alphabetic, not by date) - Apply patch - Repeat testing and very all is sorting correctly now
Created attachment 112482 [details] [review] Bug 26664: Fix sorting for date last seen in inventory tool This adds the standard datatable sorting for dates to the inventory table as described here: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference To test: - Go to the inventory tool - Search for a big sample list of items with different date last seen - Sort the table now by "date last seen" by clicking on the table header cell - Try different settings of the DateFormat system preferences - Verify sorting is incorrect (alphabetic, not by date) - Apply patch - Repeat testing and very all is sorting correctly now Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 112890 [details] [review] Bug 26664: Fix sorting for date last seen in inventory tool This adds the standard datatable sorting for dates to the inventory table as described here: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference To test: - Go to the inventory tool - Search for a big sample list of items with different date last seen - Sort the table now by "date last seen" by clicking on the table header cell - Try different settings of the DateFormat system preferences - Verify sorting is incorrect (alphabetic, not by date) - Apply patch - Repeat testing and very all is sorting correctly now Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 112891 [details] [review] Bug 26664: (QA follow-up) Add filters Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected; passes QA tests (with follow-up) Passing QA
Pushed to master for 20.11, thanks to everybody involved!