If we put Starman in to cpanfile, it will help people using cpanfile without the Debian packages, and it should mean that the dependency is automatically added to debian/control.
Created attachment 111675 [details] [review] Bug 26685: Move starman out of debian/control.in and into cpanfile
Is there a test plan that would make sense for this?
I believe Starman is not strictly required, as other PSGI servers should work as well. And we also have an option to run Koha as a Mojolicious application. Would it make sense to move it to the 'recommends' section of cpanfile instead ?
(In reply to Julian Maurice from comment #3) > I believe Starman is not strictly required, as other PSGI servers should > work as well. And we also have an option to run Koha as a Mojolicious > application. > Would it make sense to move it to the 'recommends' section of cpanfile > instead ? I think that your argument has merit, but if we want Koha to work out-of-the-box, we do need to provide a default requirement, which is going to be starman for the time being. Maybe we could put it as "recommends" in the cpanfile, and then keep "starman" in debian/control for koha-common and koha-full... and allow people to install whatever PSGI/Mojolicious server they want for koha-core... It seems that "C4/Installer/PerlModules.pm" and "debian/list-deps" won't process "recommends", so that could work... Perhaps something to discuss further..
Actually debian/list-deps processes all packages in cpanfile, even "suggests". The only difference between "requires" and the other types is that if it does not find a required package, it prints an error message. So we could remove starman from control.in, and add it in the "recommends" section of cpanfile. It should work.
Is this ready for testing? If so please add a commit message which includes a detailed test plan.
Created attachment 131227 [details] [review] Bug 26685: Move starman out of debian/control.in and into cpanfile to test... - apply patch - build and install new package - confirm starman package displays correctly in about.pl page Signed-off-by: Mason James <mtj@kohaaloha.com>
Created attachment 131228 [details] [review] Bug 26685: Move Starman out of debian/control.in and into cpanfile (2) defining package as 'recommended', as suggested
Created attachment 131229 [details] pic pic
stretch (oldoldstable) 0.4014-1: all buster (oldstable) 0.4014-3: all bullseye (stable) 0.4015-1: all bookworm (testing) 0.4015-1: all sid (unstable) 0.4015-1: all
Created attachment 131974 [details] [review] Bug 26685: Move starman out of debian/control.in and into cpanfile to test... - apply patch - build and install new package - confirm starman package displays correctly in about.pl page Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 131975 [details] [review] Bug 26685: Move Starman out of debian/control.in and into cpanfile (2) defining package as 'recommended', as suggested Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]