If a hold is requested, checked in at another branch, set to transit, then checked in but ignored at the receiving branch it can appear incorrectly on request.pl as the code checks: 1 - That there are no transfers 2 - That the items holding branch is the same as the request branch
Created attachment 111789 [details] [review] Bug 26698: Use is_at_destination to determine if hold is at destination This copies code from bug 12556 and uses a Koha::Hold method rather than code in script TO test: 1 - Place a hold for item from library B for delivery at library A 2 - Check the item in at library B, confirm and transfer 3 - Check item in at Library A but ignore the hold 4 - View the Holds tab of the details page: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=6 5 - Priority = "In transit" Pickup Library = "Item waiting at" 6 - Apply patch 7 - Restart all the thigns 8 - Reload the page 9 - Priority="In transit" and Pickup library="Item being transferred"
*** Bug 26105 has been marked as a duplicate of this bug. ***
Tried twice the test plan and at step 5 didn't got the issue. But got «Priority="In transit" and Pickup library="Item being transferred"» Does the issue still happens?
(In reply to Victor Grousset/tuxayo from comment #3) > Tried twice the test plan and at step 5 didn't got the issue. But got > «Priority="In transit" and Pickup library="Item being transferred"» > > Does the issue still happens? Are you testing on 20.05?
:o I missed that, thanks.
Created attachment 114486 [details] [review] Bug 26698: Use is_at_destination to determine if hold is at destination This copies code from bug 12556 and uses a Koha::Hold method rather than code in script TO test: 1 - Place a hold for item from library B for delivery at library A 2 - Check the item in at library B, confirm and transfer 3 - Check item in at Library A but ignore the hold 4 - View the Holds tab of the details page: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=6 5 - Priority = "In transit" Pickup Library = "Item waiting at" 6 - Apply patch 7 - Restart all the thigns 8 - Reload the page 9 - Priority="In transit" and Pickup library="Item being transferred" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
It works! :)
Created attachment 115019 [details] [review] Bug 26698: Use is_at_destination to determine if hold is at destination This copies code from bug 12556 and uses a Koha::Hold method rather than code in script TO test: 1 - Place a hold for item from library B for delivery at library A 2 - Check the item in at library B, confirm and transfer 3 - Check item in at Library A but ignore the hold 4 - View the Holds tab of the details page: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=6 5 - Priority = "In transit" Pickup Library = "Item waiting at" 6 - Apply patch 7 - Restart all the thigns 8 - Reload the page 9 - Priority="In transit" and Pickup library="Item being transferred" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix, works as expected.. Passing QA
Sending to RM 20.05 queue.
Pushed to 20.05.x for 20.05.08
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.