In Mana, when you hover over the information in the Notes column you get a popup box that shows the SQL code. It would be nice to incorporate this functionality into the list of saved reports in Koha. We don't always have notes information for our reports and the title doesn't always reveal what it is supposed to do. Being able to see the SQL code without having to open it would be helpful. Maybe providing this information in a popup when you hover over the report name would work. Also, this might not be functionality that every library would want so being able to opt in or out would be good.
This is a really good idea.
I agree.
Created attachment 115967 [details] [review] Bug 26708: Add SQL popup when hovering over name of report This patch adds an option to preview a report's SQL by selecting "Preview SQL" from the "Actions" menu. To test, apply the patch and go to Reports -> Saved reports. - In the table listing saved reports, open the "Actions" pop-up menu and click the "Preview SQL" link. - You should be shown a modal with a syntax-highlighted view of the SQL code. - The footer of the modal should have options for Edit, Duplicate, Schedule, Delete, Run report, and Close. - Test that all these buttons work correctly. - Test that all of these features work correctly any page of the saved reports DataTable.
Created attachment 115973 [details] [review] Bug 26708: Add SQL popup when hovering over name of report This patch adds an option to preview a report's SQL by selecting "Preview SQL" from the "Actions" menu. To test, apply the patch and go to Reports -> Saved reports. - In the table listing saved reports, open the "Actions" pop-up menu and click the "Preview SQL" link. - You should be shown a modal with a syntax-highlighted view of the SQL code. - The footer of the modal should have options for Edit, Duplicate, Schedule, Delete, Run report, and Close. - Test that all these buttons work correctly. - Test that all of these features work correctly any page of the saved reports DataTable.
Created attachment 115974 [details] [review] Bug 26708: Add SQL popup when hovering over name of report This patch adds an option to preview a report's SQL by selecting "Preview SQL" from the "Actions" menu. To test, apply the patch and go to Reports -> Saved reports. - In the table listing saved reports, open the "Actions" pop-up menu and click the "Preview SQL" link. - You should be shown a modal with a syntax-highlighted view of the SQL code. - The footer of the modal should have options for Edit, Duplicate, Schedule, Delete, Run report, and Close. - Test that all these buttons work correctly. - Test that all of these features work correctly any page of the saved reports DataTable. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
I really like this popup for previewing the SQL and that it includes all of the different actions right from the popup.
I wonder if this should not replace the "View" which does the same as the "Preview" now. Is there a reason to keep both? Can you please also adjust the bug description as this has now been solved a little differently than initially suggested?
(In reply to Katrin Fischer from comment #7) > I wonder if this should not replace the "View" which does the same as the > "Preview" now. Is there a reason to keep both? I think a static page is always a good option to have--opening the view in a new tab, for instance, for referring to without worrying that the modal will close because of an accidental click.
Created attachment 116473 [details] [review] Bug 26708: Add SQL popup when hovering over name of report This patch adds an option to preview a report's SQL by selecting "Preview SQL" from the "Actions" menu. To test, apply the patch and go to Reports -> Saved reports. - In the table listing saved reports, open the "Actions" pop-up menu and click the "Preview SQL" link. - You should be shown a modal with a syntax-highlighted view of the SQL code. - The footer of the modal should have options for Edit, Duplicate, Schedule, Delete, Run report, and Close. - Test that all these buttons work correctly. - Test that all of these features work correctly any page of the saved reports DataTable. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x
In my opinion, this may replace the "View" action