In the OPAC "Your Reading History" seems misnamed since patrons also check out DVDs, music, audio books, kits, library of things, etc. It seems like a more accurate name would be "Your Checkout History"
Hi Barbara, first of all: thx for all the bug reports! I think you have a very good point here. +1
Created attachment 111942 [details] [review] Bug 26718: Rename "reading history" to "checkout history" This changes all occurences of reading history to the more accurate term 'checokut history' as it was correctly pointed out that 'reading' doesn't apply to all kind of items available at the library (audio books, games, etc.) To test: - Verify that the term reding history has been replaced by checkout history in: - System preferences - OPAC tab "your checkout history" - OPAC tab "your privacy" (switch OpacPrivacy pref first) - Staff permission for patron batch anonymization
I've written up a patch with the suggested change - please check and discuss!
Everything worked for me except the change for the system preferences. They still display as opacreadinghistory and intranetreadinghistory. Also still displays opacreadinghistory in the description for the StoreLastBorrower system preference.
Hi Barbara, thx for testing. I didn't rename the preferences, only changed the description texts and labels in the GUI. Renaming the prefs would require more work and they are only visible to system librarians, so hope I can get away with that :)
Created attachment 111949 [details] [review] Bug 26718: Rename "reading history" to "checkout history" This changes all occurences of reading history to the more accurate term 'checokut history' as it was correctly pointed out that 'reading' doesn't apply to all kind of items available at the library (audio books, games, etc.) To test: - Verify that the term reding history has been replaced by checkout history in: - System preferences - OPAC tab "your checkout history" - OPAC tab "your privacy" (switch OpacPrivacy pref first) - Staff permission for patron batch anonymization Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Katrin, thanks for clarifying that. So it all works as expected and I’ve signed off.
Thank you!
Created attachment 112109 [details] [review] Bug 26718: Rename "reading history" to "checkout history" This changes all occurences of reading history to the more accurate term 'checokut history' as it was correctly pointed out that 'reading' doesn't apply to all kind of items available at the library (audio books, games, etc.) To test: - Verify that the term reding history has been replaced by checkout history in: - System preferences - OPAC tab "your checkout history" - OPAC tab "your privacy" (switch OpacPrivacy pref first) - Staff permission for patron batch anonymization Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice clarification.. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x