The patch for Bug 25351 removed definition of the MSG_NO_RECORD_SELECTED variable but didn't correct all the instances where the variable is used. These instances need to be fixed with a string wrapped in the new i18n function.
Created attachment 111932 [details] [review] Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string This patch cleans up some loose ends left by Bug 25351, replacing instances where the undefined variable MSG_NO_RECORD_SELECTED is used. To test, apply the patch and perform a catalog search in the OPAC. - On the search results page, without checking any checkboxes, use the "Select titles to..." menu to try to add to cart and add to a list. In each case you should get a "No item was selected" message. - View a list which contains one or more titles. Click the "Remove from list" link. You should get a "No item was selected" link. Other instances have been corrected even though they will only be triggered if something has broken. For instance, toolbar items in the cart window which are disabled shouldn't register the click that might trigger the error. And selecting an item for an item-level hold shouldn't ever give a warning because at least one radio button should always be selected.
Created attachment 111933 [details] [review] Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string This patch cleans up some loose ends left by Bug 25351, replacing instances where the undefined variable MSG_NO_RECORD_SELECTED is used. To test, apply the patch and perform a catalog search in the OPAC. - On the search results page, without checking any checkboxes, use the "Select titles to..." menu to try to add to cart and add to a list. In each case you should get a "No item was selected" message. - View a list which contains one or more titles. Click the "Remove from list" link. You should get a "No item was selected" link. Other instances have been corrected even though they will only be triggered if something has broken. For instance, toolbar items in the cart window which are disabled shouldn't register the click that might trigger the error. And selecting an item for an item-level hold shouldn't ever give a warning because at least one radio button should always be selected. Signed-off-by: David Nind <david@davidnind.com>
I've added bug 26720 as the your lists buttons don't seem to be displaying correctly.
Hi Owen, is there a chance we could add context here or use another word than "item"? A list item and a record's item require different translation in German.
Created attachment 112033 [details] [review] Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string This patch cleans up some loose ends left by Bug 25351, replacing instances where the undefined variable MSG_NO_RECORD_SELECTED is used. To test, apply the patch and perform a catalog search in the OPAC. - On the search results page, without checking any checkboxes, use the "Select titles to..." menu to try to add to cart and add to a list. In each case you should get a "No item was selected" message. - View a list which contains one or more titles. Click the "Remove from list" link. You should get a "No item was selected" link. Other instances have been corrected even though they will only be triggered if something has broken. For instance, toolbar items in the cart window which are disabled shouldn't register the click that might trigger the error. And selecting an item for an item-level hold shouldn't ever give a warning because at least one radio button should always be selected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
does not apply clean to 20.05.x, no backport if needed please rebase