At the moment, the pages check for: admin/credit_types.pl: flagsrequired => { parameters => 'parameters_remaining_permissions' }, admin/debit_types.pl: flagsrequired => { parameters => 'parameters_remaining_permissions' }, But the templates like admin home page check for the correct specific permission: [% IF ( CAN_user_parameters_manage_accounts ) %]
Created attachment 111947 [details] [review] Bug 26721: Fix permission check on debit and credit type admin pages At the moment the pages falsely check for parameters_remaining_permissions, but they should check the specific manage_accounts permission. To test: - Create a new staff user with only catalog and manage_acccounts permissions - Log in with this staff user and go to the admin page - You will see the debit and credit type sections, but won't be able to access them - Apply the patch - Veriy the links still show, but pages are now accessible
Created attachment 112481 [details] [review] Bug 26721: Fix permission check on debit and credit type admin pages At the moment the pages falsely check for parameters_remaining_permissions, but they should check the specific manage_accounts permission. To test: - Create a new staff user with only catalog and manage_acccounts permissions - Log in with this staff user and go to the admin page - You will see the debit and credit type sections, but won't be able to access them - Apply the patch - Veriy the links still show, but pages are now accessible Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 112825 [details] [review] Bug 26721: Fix permission check on debit and credit type admin pages At the moment the pages falsely check for parameters_remaining_permissions, but they should check the specific manage_accounts permission. To test: - Create a new staff user with only catalog and manage_acccounts permissions - Log in with this staff user and go to the admin page - You will see the debit and credit type sections, but won't be able to access them - Apply the patch - Veriy the links still show, but pages are now accessible Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Dang.. how did I get these mismatched! Works as expected, thanks for the fix Katrin. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
does not apply cleanly to 20.05.x, no backport